flake8
passed.
JSHint
passed.
Add review bot tool for chardet
Review Request #9531 — Created Jan. 25, 2018 and discarded
Sometimes it is a rule to use ascii or utf-8 for your java or c++ files only. As it is really easy to miss some weird characters this checker allows to detect forbidden encodings for you.
Added ascii check, uploaded patch with utf-8
character and saw that it finds the correct line.
| Description | From | Last Updated |
|---|---|---|
|
README.rst files in each of /, /bot/, and /extension/ also need to list the new tool. |
 david
|
|
|
Should use PEP-8 groupings: from os.path import splitext from reviewbot.tools import Tool import chardet |
david
|
|
|
When joining strings across lines, we put the space and the end of the line instead of the start of … |
david
|
|
|
When joining strings across lines, we put the space and the end of the line instead of the start of … |
david
|
|
|
I think it probably makes more sense to do this at a file level rather than per-line. |
david
|
|
|
Can you rebase onto master and change this to use the new optional depedencies structure we have there? |
david
|
|
|
This should probably use "ASCII" and "UTF-8" instead of lower-cased. |
david
|
|
|
When updating to master, this will need to change too. |
david
|
|
|
F401 'chardet' imported but unused |
 reviewbot
|
- Commit:
-
3323d8360fa6fffb58af00b24f451ead1d5b2026780c46927640120410f2bfe18e3a037841d1fbd1
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Commit:
-
780c46927640120410f2bfe18e3a037841d1fbd1d04b19d9f01e801eb70c522e838de57d6bb23893
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Commit:
-
d04b19d9f01e801eb70c522e838de57d6bb238931ed3deb68b8a663dd4ccebe436b64a48ac6e0bf1
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Testing Done:
-
+ Added ascii check, uploaded patch with utf-8
+ character and saw that it finds the correct line. - Commit:
-
1ed3deb68b8a663dd4ccebe436b64a48ac6e0bf108000a5523d346721dd0ed6ff32925002eef5065
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
rebase
- Branch:
-
masterrelease-1.0.x
- Commit:
-
08000a5523d346721dd0ed6ff32925002eef5065eaa47138ea1f08572ef7bd7123d91b85a626cde4
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
-
Should use PEP-8 groupings:
from os.path import splitext from reviewbot.tools import Tool import chardet -
When joining strings across lines, we put the space and the end of the line instead of the start of the next.
-
When joining strings across lines, we put the space and the end of the line instead of the start of the next.
-
-
Can you rebase onto master and change this to use the new optional depedencies structure we have there?
-
-