Add support for XML config file and use outfile for results

Review Request #9516 — Created Jan. 22, 2018 and submitted

misery
ReviewBot
master
eef1cac...
reviewbot
If a user has a complex ruleset file he can paste the whole
configuration to the ReviewBot config.

Redirect check result to output file as pmd could still
print some warnings that will break any parsing of CSV
output.

Used basic ruleset as cmdline parameter and saw correct results.

Paste a 6kb big xml config file and saw correct results.

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
misery
david
  1. 
      
  2. bot/reviewbot/tools/pmd.py (Diff revision 1)
     
     

    Add a blank line after this.

  3. bot/reviewbot/tools/pmd.py (Diff revision 1)
     
     

    This will leak a file descriptor. We should do:

    with open(outfile) as f:
        reader = csv.DictReader(f)
    
        for row in reader:
            ...
    
  4. 
      
misery
david
  1. Ship It!
  2. 
      
misery
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (f95629e)
Loading...