Summary

Add support for XML config file and use outfile for results

Review Request #9516 — Created Jan. 22, 2018 and submitted Jan. 24, 2018, 1:32 p.m.

Information

Owner

misery

Repository

ReviewBot

Branch

master

Bugs

Depends On

Commit

eef1cac...

Reviewers

Groups

reviewbot

People

Description

If a user has a complex ruleset file he can paste the whole
configuration to the ReviewBot config.

Redirect check result to output file as pmd could still
print some warnings that will break any parsing of CSV
output.

Testing Done

Used basic ruleset as cmdline parameter and saw correct results.

Paste a 6kb big xml config file and saw correct results.

Issues

Description	From	Last Updated
Add a blank line after this.	david	Jan. 23, 2018, 11:38 p.m.
This will leak a file descriptor. We should do: with open(outfile) as f: reader = csv.DictReader(f) for row in reader: …	david	Jan. 23, 2018, 11:39 p.m.

flake8 passed.

JSHint passed.

Testing Done:: +
Used basic ruleset as cmdline parameter and saw correct results.
+
+
Paste a 6kb big xml config file and saw correct results.

bot/reviewbot/tools/pmd.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Add a blank line after this.
```

bot/reviewbot/tools/pmd.py (Diff revision 1)

The issue has been resolved. Show all issues

This will leak a file descriptor. We should do:

with open(outfile) as f:
    reader = csv.DictReader(f)

    for row in reader:
        ...

Commit:

7aa58b136c1e79de568a69005b19692a9ffe891a

eef1cac9dcc08ec64ff453eb0ea31d5723c20477

Diff:

Revision 2 (+28 -8)

Show changes

bot/reviewbot/tools/pmd.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (f95629e)