• 
      

    Reject git diff filenames with absolute path

    Review Request #9512 — Created Jan. 20, 2018 and updated

    Information

    Review Board
    release-2.0.x
    3c76a5c...

    Reviewers

    Filenames in git diff files should be relative path and not
    absolute path. This EasyFix raises an error when an
    absolute path is detected.

    Added unit test to test parsing Git diff with absolute file names
    All tests passed in reviewboard.scmtools.tests.test_git:GitTests

    Description From Last Updated

    Does this have an associated ticket on Splat? If so, can you link it? If not (actually, even if so), …

    david david

    E501 line too long (81 > 79 characters)

    reviewbot reviewbot

    E501 line too long (83 > 79 characters)

    reviewbot reviewbot

    E501 line too long (83 > 79 characters)

    reviewbot reviewbot

    E127 continuation line over-indented for visual indent

    reviewbot reviewbot

    E501 line too long (83 > 79 characters)

    reviewbot reviewbot

    E127 continuation line over-indented for visual indent

    reviewbot reviewbot
    Checks run (1 failed, 1 succeeded)
    flake8 failed.
    JSHint passed.

    flake8

    JQ
    Review request changed
    Commit:
    3843624ee4a896bb5eddf81ec8ffd5973a18e2f4
    3c76a5cd0e5f548f1d4ecf7d3678c110cdc16745

    Checks run (2 succeeded)

    flake8 passed.
    JSHint passed.
    david
    1. 
        
    2. Show all issues

      Does this have an associated ticket on Splat? If so, can you link it?

      If not (actually, even if so), can you flesh out the description to describe where we've run into this and why it's a problem?

    3.