Summary

Added tests for `parse_timestmp` of `djblets.log.views` to address missing test cases

Review Request #9504 — Created Jan. 20, 2018 and updated Jan. 24, 2018, 10:01 p.m.

Information

Owner

rodgerwa

Repository

Djblets

Branch

master

Bugs

4590

Depends On

Commit

80559c5...

Reviewers

Groups

djblets

People

Description

Added tests for djblets.log.views for testing the parse_timestamp
function.

The included tests try the following cases with provided timestamp
format string:
- Empty String of '' being passed
- A string containing something other than a date ('jibberish')
- An invalid date where the month is out of bounds
('1990-55-09 22:11:30')
- A valid date input string ('1990-01-01 20:20:20')

Based most of this behavior off how parse_timestamp behaved in the
interpreter with various inputs. To be more accurate with testing
would require the default implementation for time and datetime,
which mightbe something to be considered with future changes to
python versions however but isn't required for
the scope of this project.

Testing Done

I ran ./tests/runtests djblets.log.tests and
./tests/runtests djblets.log and both pass along with
all other test cases.

Issues

Description	From	Last Updated
Your testing done should be capititalized appropriately. You can make the bits look like code with: `code`	brennie	Jan. 20, 2018, 11:32 a.m.
The bug number should go in the bugs field. The bug number should not be in the summary or description.	brennie	Jan. 20, 2018, 11:32 a.m.
You will want to give our guide on change descriptions a read and edit your summary and description to match. …	brennie	Jan. 20, 2018, 11:38 a.m.
Can you wrap your description and testing done at 72 characters?	brennie	Jan. 20, 2018, 12:20 p.m.
Testing done needs to be capitalized and should end in a period.	brennie	Jan. 20, 2018, 12:20 p.m.
Needs a file-level docstring describing the module. "Unit tests for djblets.log.views" is fine.	brennie	Jan. 20, 2018, 11:31 a.m.
Unnecessary.	brennie	Jan. 20, 2018, 11:31 a.m.
Needs a docstring.	brennie	Jan. 20, 2018, 11:31 a.m.
Needs a docstring.	brennie	Jan. 20, 2018, 11:31 a.m.
Needs a docstring.	brennie	Jan. 20, 2018, 11:31 a.m.
Needs a docstring. invalid_date.	brennie	Jan. 20, 2018, 11:31 a.m.
valid_date (reads like validate otherwise) Also needs a docstring.	brennie	Jan. 20, 2018, 11:31 a.m.
Test docstrings shouldn't end in periods because the test runner will append a "..."	david	Jan. 20, 2018, 12:20 p.m.
Same heere.	david	Jan. 20, 2018, 12:20 p.m.
And here.	david	Jan. 20, 2018, 12:19 p.m.
And here.	david	Jan. 20, 2018, 12:19 p.m.
Proper grammar should be "There aren't 55 months"	david	Jan. 24, 2018, 10:01 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Fixed description

Summary:

-	Added test for djblets.log.views to address [4590](https://hellosplat.com/s/beanbag/tickets/4590/)
+	Added test for djblets.log.views to address 4590

Show all issues

Your testing done should be capititalized appropriately.

You can make the bits look like code with:

`code`

Show all issues

The bug number should go in the bugs field.

The bug number should not be in the summary or description.

Show all issues

You will want to give our guide on change descriptions a read and edit your summary and description to match. Change descriptions should be stand-alone and not require looking up a bug to find out what the change does.

rodgerwa Jan. 20, 2018, 11:33 a.m.

I think my latted change addresses this. Let me know.

RO

rodgerwa Jan. 20, 2018, 11:33 a.m.
```
lattest*
```

djblets/log/tests/test_log_views.py (Diff revision 1)

Show all issues

Needs a file-level docstring describing the module. "Unit tests for djblets.log.views" is fine.

rodgerwa Jan. 20, 2018, 11:33 a.m.

So add a docstring for the first line of the file?

djblets/log/tests/test_log_views.py (Diff revision 1)
Show all issues
```
Unnecessary.
```
djblets/log/tests/test_log_views.py (Diff revision 1)
Show all issues
```
Needs a docstring.
```
djblets/log/tests/test_log_views.py (Diff revision 1)
Show all issues
```
Needs a docstring.
```
djblets/log/tests/test_log_views.py (Diff revision 1)
Show all issues
```
Needs a docstring.
```
djblets/log/tests/test_log_views.py (Diff revision 1)
Show all issues
```
Needs a docstring. invalid_date.
```

djblets/log/tests/test_log_views.py (Diff revision 1)

Show all issues

valid_date (reads like validate otherwise)
Also needs a docstring.

Change Summary:

updated description

Description:

~		Added test for djblets.log.views to address 4590
	~	Added tests for `djblets.log.views` for testing the `parse_timestamp` function.
	+
	+	The included tests try the following cases with provided timestamp format string:
	+	- Empty String of `''` being passed
	+	- A string containing something other than a date (`'jibberish'`)
	+	- An invalid date where the month is out of bounds (`'1990-55-09 22:11:30'`)
	+	- A valid date input string (`'1990-01-01 20:20:20'`)
	+
	+	Based most of this behavior off how `parse_timestamp` behaved in the interpreter with various inputs. To get more accurate testing would be testing the default implementation for time and datetime, which might be something to be considered with future changes to python version however isn't required for the scope of this project.
	+
	+	This is based off 4590 which was requesting test cases to prevent possible regressions in `djblets.log.views` since no tests were provided for this file.
	+	This doesn't resolve 4590 but it addresses part of the issue.

Testing Done:

~		ran './tests/runtests djblets.log.tests' and './tests/runtests djblets.log'
	~	ran `./tests/runtests djblets.log.tests` and `./tests/runtests djblets.log` and both pass along with all other test cases

Bugs:

+	4590

Change Summary:

Addressed comments raised by Barret about missing doc strings, typo's in function names, and unnecessary comment.

Diff:

Revision 2 (+33)

Show changes

djblets/log/tests/test_log_views.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	Added test for djblets.log.views to address 4590
+	Added tests for `parse_timestmp` of `djblets.log.views` to address missing test cases

Description:

		Added tests for `djblets.log.views` for testing the `parse_timestamp` function.

		The included tests try the following cases with provided timestamp format string:
		- Empty String of `''` being passed
		- A string containing something other than a date (`'jibberish'`)
		- An invalid date where the month is out of bounds (`'1990-55-09 22:11:30'`)
		- A valid date input string (`'1990-01-01 20:20:20'`)

		Based most of this behavior off how `parse_timestamp` behaved in the interpreter with various inputs. To get more accurate testing would be testing the default implementation for time and datetime, which might be something to be considered with future changes to python version however isn't required for the scope of this project.
-
-		This is based off 4590 which was requesting test cases to prevent possible regressions in `djblets.log.views` since no tests were provided for this file.
-		This doesn't resolve 4590 but it addresses part of the issue.

Show all issues

Can you wrap your description and testing done at 72 characters?

Show all issues

Testing done needs to be capitalized and should end in a period.

djblets/log/tests/test_log_views.py (Diff revision 2)

Show all issues

Test docstrings shouldn't end in periods because the test runner will append a "..."

djblets/log/tests/test_log_views.py (Diff revision 2)
Show all issues
```
Same heere.
```
djblets/log/tests/test_log_views.py (Diff revision 2)
Show all issues
```
And here.
```
djblets/log/tests/test_log_views.py (Diff revision 2)
Show all issues
```
And here.
```

Change Summary:

Address formatting, punctuation, and doctrings

Description:

~		Added tests for `djblets.log.views` for testing the `parse_timestamp` function.
	~	Added tests for `djblets.log.views` for testing the `parse_timestamp`
	+	function.

~		The included tests try the following cases with provided timestamp format string:
	~	The included tests try the following cases with provided timestamp
	+	format string:
		- Empty String of `''` being passed
		- A string containing something other than a date (`'jibberish'`)
~		- An invalid date where the month is out of bounds (`'1990-55-09 22:11:30'`)
	~	- An invalid date where the month is out of bounds
	+	(`'1990-55-09 22:11:30'`)
		- A valid date input string (`'1990-01-01 20:20:20'`)

~		Based most of this behavior off how `parse_timestamp` behaved in the interpreter with various inputs. To get more accurate testing would be testing the default implementation for time and datetime, which might be something to be considered with future changes to python version however isn't required for the scope of this project.
	~	Based most of this behavior off how `parse_timestamp` behaved in the
	+	interpreter with various inputs. To be more accurate with testing
	+	would require the default implementation for time and datetime,
	+	which mightbe something to be considered with future changes to
	+	python versions however but isn't required for
	+	the scope of this project.

Testing Done:

~		ran `./tests/runtests djblets.log.tests` and `./tests/runtests djblets.log` and both pass along with all other test cases
	~	I ran `./tests/runtests djblets.log.tests` and
	+	`./tests/runtests djblets.log` and both pass along with
	+	all other test cases.

Diff:

Revision 3 (+33)

Show changes

djblets/log/tests/test_log_views.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Fix it!

djblets/log/tests/test_log_views.py (Diff revision 3)
Show all issues
```
Proper grammar should be "There aren't 55 months"
```