Delete an unused variable in UsernameColumn.py

Review Request #9495 — Created Jan. 19, 2018 and submitted

ridum
Review Board
release-3.0.x
4630
3ff35c2...
reviewboard, students

The user_url variable is dead code that accidentally wasn't removed
in 43957396.
This patch removes the unused variable.

Manual:
* Linted user_url and no longer saw an unused variable.

Automated:
* Ran unit tests.

  • 0
  • 0
  • 7
  • 0
  • 7
Description From Last Updated
brennie
  1. You will want to give our guide on writing on change descriptions a read.

  2. 4630 should go in the bugs field.

  3. Your summary should be a high-level overview of your change. It shouldn't require looking up the bug number.

  4. You'll need to fill out the testing done field.

  5. 
      
mike_conley
  1. 
      
  2. This change looks fine, but I have one minor nit regarding the Description:

    due to the recent update

    If you're referring to a particular update, you might want to mention which one.

    I just took a quick look at reviewboard/datagrids/columns.py, and it looks like it was this change:

    https://github.com/reviewboard/reviewboard/commit/439573964de820cb8663ba95db50ad02d9226794#diff-2a6f9481a47b04e51de14d94fc1999d1

    So perhaps you could change this to:

    The "user_url" variable is dead code that accidentally wasn't removed in 43957396. This patch removes the unused variable.

  3. 
      
david
  1. A few last small requests about the summary/description:

    • Please start your summary with a capital letter ("Delete ...")
    • You have a typo in the summary (varibale -> variable)
    • The summary should be "Delete an unused..."
    • Please wrap the description to 70 columns.
    1. done :P thanks for pointing out

  2. 
      
mike_conley
  1. This looks good to me. Thanks!

    1. Whoops - revoking ship-it; I didn't notice that David had some follow-ups.

  2. 
      
brennie
  1. 
      
  2. You can mark things as code using backquotes, e.g:

    The `user_url`
    
  3. Mind formatting the testing done as:

    * Ran unit tests.
    * Linted the file and no longer saw an unused variable.
    
  4. Mind wrapping your description at 72chars?

  5. 
      
mike_conley
  1. Looks good to me! Thanks!

  2. 
      
david
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (8a8fd3e)
Loading...