flake8
failed.
JSHint
passed.
flake8
-
djblets/siteconfig/models.py (Diff revision 1)
Clean up and modernize the siteconfig code.
Review Request #9482 — Created Jan. 14, 2018 and submitted
The siteconfig code is some of the oldest in Djblets, and doesn't live
up to current standards for documentation and testing. This change
improves all this, fleshing out the docs, splitting up unit tests, and
changing a few small pieces of code to be just a little more efficient
(making better use of built-in Python functionality).
All unit tests for Djblets and Review Board pass.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+425 -298) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
-
-
djblets/siteconfig/django_settings.py (Diff revision 2) I think the term should probably be "settings key", not "setting key". Same throughout this docstring.
Change Summary:
- Fixed a bad copy/paste causing a "Returns" section to be "Return".
- Chnaged "setting key" to "settings key" throughout all the docs.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+425 -298) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.