Clean up and modernize the siteconfig code.

Review Request #9482 — Created Jan. 14, 2018 and submitted

Information

Djblets
release-1.0.x
24f69fe...

Reviewers

The siteconfig code is some of the oldest in Djblets, and doesn't live
up to current standards for documentation and testing. This change
improves all this, fleshing out the docs, splitting up unit tests, and
changing a few small pieces of code to be just a little more efficient
(making better use of built-in Python functionality).

All unit tests for Djblets and Review Board pass.

Description From Last Updated

F821 undefined name 'name'

reviewbotreviewbot

typo: Return -> Returns

daviddavid

Typo: Return -> Returns

daviddavid

I think the term should probably be "settings key", not "setting key". Same throughout this docstring.

daviddavid
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. 
      
  2. Show all issues

    typo: Return -> Returns

  3. Show all issues

    Typo: Return -> Returns

  4. djblets/siteconfig/django_settings.py (Diff revision 2)
     
     
    Show all issues

    I think the term should probably be "settings key", not "setting key". Same throughout this docstring.

  5. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-1.0.x (1d8f1ca)