Add a line-height to .avatar-missing.

Review Request #9465 — Created Dec. 29, 2017 and submitted

Information

Djblets
release-1.0.x
ec1f016...

Reviewers

The missing avatar display didn't define the line height, which meant we
were at the mercy of the element's inherted vertical alignment. This
change fixes that so that the size of the question mark element is
always the same height as its container.

Saw the correct alignment in both Review Board and elsewhere.

Description From Last Updated

Can we add a constant for all this?

chipx86chipx86

Can you set this to @avatar-size + 2px? It's for the border.

chipx86chipx86
chipx86
  1. 
      
  2. djblets/static/djblets/css/avatars.less (Diff revision 1)
     
     
     
     
     
    Show all issues

    Can we add a constant for all this?

  3. 
      
david
chipx86
  1. 
      
  2. djblets/static/djblets/css/avatars.less (Diff revision 2)
     
     
    Show all issues

    Can you set this to @avatar-size + 2px? It's for the border.

  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (7ebdd75)
Loading...