Summary

Add a line-height to .avatar-missing.

Review Request #9465 — Created Dec. 29, 2017 and submitted Jan. 3, 2018, 4:05 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-1.0.x

Bugs

Depends On

Commit

ec1f016...

Reviewers

Groups

djblets

People

Description

The missing avatar display didn't define the line height, which meant we
were at the mercy of the element's inherted vertical alignment. This
change fixes that so that the size of the question mark element is
always the same height as its container.

Testing Done

Saw the correct alignment in both Review Board and elsewhere.

Issues

Description	From	Last Updated
Can we add a constant for all this?	chipx86	Dec. 30, 2017, 2:39 p.m.
Can you set this to @avatar-size + 2px? It's for the border.	chipx86	Jan. 3, 2018, 4:04 p.m.

flake8 passed.

JSHint passed.

djblets/static/djblets/css/avatars.less (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we add a constant for all this?
```

Commit:

271fd7e988e78fba3eaf629148ccfcb8e8aad690

ec1f0167fb3b6f605c3150f1290e825335892480

Diff:

Revision 2 (+8 -5)

Show changes

djblets/static/djblets/css/avatars.less

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

djblets/static/djblets/css/avatars.less (Diff revision 2)
The issue has been resolved. Show all issues
```
Can you set this to @avatar-size + 2px? It's for the border.
```

Status:: Completed
Change Summary:: Pushed to release-1.0.x (7ebdd75)