Cleanup user creation in tests

Review Request #9458 — Created Dec. 19, 2017 and submitted — Latest diff uploaded

Information

Review Board
release-3.0.x
879fdfd...

Reviewers

We now are always careful to provide an e-mail to users in tests. Also,
calls have been updated to use User.objects.create_user over
User.objects.create where appropriate. This was prompted by a change
in Djblets (see https://reviews.reviewboard.org/r/9445/) which started
causing unit test failures due to Users without e-mail addresses
being serialized. So to be extra safe, I've gone in and added e-mail
addresses to all calls that were lacking them.

Ran unit tests.

reviewboard/accounts/tests.py
reviewboard/attachments/tests.py
reviewboard/avatars/tests.py
reviewboard/changedescs/tests.py
reviewboard/extensions/tests.py
reviewboard/notifications/tests.py
reviewboard/reviews/tests/test_actions.py
reviewboard/reviews/tests/test_counters.py
reviewboard/reviews/tests/test_default_groups.py
reviewboard/reviews/tests/test_default_reviewer.py
reviewboard/reviews/tests/test_entries.py
reviewboard/reviews/tests/test_forms.py
reviewboard/reviews/tests/test_policy.py
reviewboard/reviews/tests/test_review.py
reviewboard/reviews/tests/test_review_request_draft.py
reviewboard/reviews/tests/test_reviewtags.py
reviewboard/reviews/tests/test_views.py
reviewboard/scmtools/tests/test_policy.py
reviewboard/site/tests.py
Loading...