This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-1.0.x (78ced0d)

Summary

Always lowercase and strip e-mail addresses for gravatar URL computation

Review Request #9445 — Created Dec. 15, 2017 and submitted 7 years, 5 months ago

Information

Owner

brennie*

Repository

Djblets

Branch

release-1.0.x

Bugs

Depends On

Commit

f01c6bb...

Reviewers

Groups

djblets

People

Description*

We now always strip whitespace and lowercase e-mails inside
get_gravatar_url_for_email, instead of having the logic inside of
get_gravatar_url. This will ensure that e-mail hashes are always
generated correctly.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
One group, and alphabetical.	chipx86	7 years, 6 months ago
We should normalize first, and then check if email is falsy (instead of just None).	chipx86	7 years, 6 months ago
This can be combined.	chipx86	7 years, 6 months ago
No blank line here.	chipx86	7 years, 6 months ago
Ending paren should be on the previous line. Same with others further down.	chipx86	7 years, 6 months ago
Can you make this one line?	chipx86	7 years, 6 months ago
Ending paren should be on the last attribute, which shouldn't have a comma. These can also start right after create_user(. …	chipx86	7 years, 6 months ago
There are no open issues

flake8 passed.

JSHint passed.

djblets/gravatars/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
One group, and alphabetical.
```

djblets/gravatars/__init__.py (Diff revision 1)

The issue has been resolved. Show all issues

We should normalize first, and then check if email is falsy (instead of just None).

djblets/gravatars/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This can be combined.
```
djblets/gravatars/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
No blank line here.
```

djblets/gravatars/tests.py (Diff revision 1)

The issue has been resolved. Show all issues

Ending paren should be on the previous line.

Same with others further down.

djblets/gravatars/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you make this one line?
```

djblets/gravatars/tests.py (Diff revision 1)

The issue has been resolved. Show all issues

Ending paren should be on the last attribute, which shouldn't have a comma.

These can also start right after create_user(.

Same with calls below.

Change Summary:

Addressed Christian's issues

Commit:

d78e10a71534988804384c33baf59e87b504ac6e

f01c6bbec5501febbb73b9e40d3b3090806c70a7

Diff:

Revision 2 (+75 -6)

Show changes

	djblets/gravatars/__init__.py
	djblets/gravatars/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.0.x (78ced0d)