Add and refine template tags for working with image srcsets.

Review Request #9440 — Created Dec. 14, 2017 and submitted

Information

Djblets
release-1.0.x
decf972...

Reviewers

The existing {% srcset %} template tag has been made more robust,
sanity-checking the sources passed in and sorting the resulting list, in
order to guarantee that the data being passed into the template is
valid. It also no longer trusts that the values provided are HTML-safe,
instead using format_html_join to more intelligently handle safe vs.
non-safe values.

A new template tag was also added, {% image_source_attrs %}, which
takes a multi-line source definition list with items in the form of
<descriptor> <URL> and builds a src="..." srcset="..." string for
adding to an <img> tag. This is a convenient way of building these
values in HTML templates without worrying about long lines, duplicate
information, and redundant calls to {% static %}.

Unit tests were added for both functions.

Unit tests pass.

Made use of this in some upcoming work in RBCommons.

david
  1. Love it!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (3cdc9c1)
Loading...