Add some polish to read-only mode.

Review Request #9437 — Created Dec. 11, 2017 and submitted

David Trowbridge
Review Board
master
58c712d...
reviewboard

This change makes some small polish changes to fix up some issues that I
noticed while testing Kanghee Park's read-only mode changes:

  • Hide the "Markdown" link in the comment dialog.
  • Fix the spacing in the comment dialog.
  • Fix up cursors and interaction for the star and archive functions.
  • Make it so that the banner is always shown when read-only mode is
    enabled, even for admins that can still interact with everything.

Verified the look and functionality of these changes.

  • 0
  • 0
  • 2
  • 1
  • 3
Description From Last Updated
Christian Hammond
  1. 
      
  2. Alphabetical order.

  3. Alphabetical order.

  4. reviewboard/templates/base.html (Diff revision 1)
     
     

    Why the discrepency between this and is_read_only? Is the former not used for admins?

    1. Yeah. is_read_only is used to disable functionality so it's always false for admins. This meant that the banner wasn't appearing for admins, so it was very hard to remember that read only mode was turned on.

  5. 
      
David Trowbridge
Christian Hammond
  1. Ship It!
  2. 
      
David Trowbridge
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (4ace9ec)
Loading...