Summary

Add some polish to read-only mode.

Review Request #9437 — Created Dec. 11, 2017 and submitted Jan. 10, 2018, 2:25 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

58c712d...

Reviewers

Groups

reviewboard

People

Description

This change makes some small polish changes to fix up some issues that I
noticed while testing Kanghee Park's read-only mode changes:

Hide the "Markdown" link in the comment dialog.
Fix the spacing in the comment dialog.
Fix up cursors and interaction for the star and archive functions.
Make it so that the banner is always shown when read-only mode is
enabled, even for admins that can still interact with everything.

Testing Done

Verified the look and functionality of these changes.

Issues

Description	From	Last Updated
Alphabetical order.	chipx86	Jan. 9, 2018, 10:14 p.m.
Alphabetical order.	chipx86	Jan. 9, 2018, 10:14 p.m.
Why the discrepency between this and is_read_only? Is the former not used for admins?	chipx86	Jan. 9, 2018, 10:13 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/css/pages/review-request.less (Diff revision 1)
The issue has been resolved. Show all issues
```
Alphabetical order.
```
reviewboard/static/rb/css/pages/review-request.less (Diff revision 1)
The issue has been resolved. Show all issues
```
Alphabetical order.
```

reviewboard/templates/base.html (Diff revision 1)

The issue has been dropped. Show all issues

Why the discrepency between this and is_read_only? Is the former not used for admins?

david Jan. 9, 2018, 10:14 p.m.

Yeah. is_read_only is used to disable functionality so it's always false for admins. This meant that the banner wasn't appearing for admins, so it was very hard to remember that read only mode was turned on.

Commit:

2414bd07ed3e9b2c5ab5c7150072aaa90a447db3

58c712db39098eb0055d7c815dfdee8af3b985b9

Diff:

Revision 2 (+34 -7)

Show changes

	reviewboard/static/rb/css/pages/review-request.less
	reviewboard/static/rb/js/views/commentDialogView.es6.js
	reviewboard/templates/base.html
	reviewboard/templates/reviews/review_request_header.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (4ace9ec)