Fix a regression with searching for closed review requests.

Review Request #9424 — Created Dec. 4, 2017 and submitted — Latest diff uploaded

Information

Review Board
release-2.5.x
b1ee849...

Reviewers

When the search API was rewritten, it was updated to use public() in
order to be more secure. This ended up using the default of only
returning opened review requests, excluding any closed ones, regressing
the ability to match those in the quick search results.

This changes that query to not limit results to open review requests,
and adds unit tests to ensure this doesn't regress.

Unit tests pass. They failed prior to the fix.