Fix a regression with searching for closed review requests.

Review Request #9424 — Created Dec. 4, 2017 and submitted

Christian Hammond
Review Board

When the search API was rewritten, it was updated to use public() in
order to be more secure. This ended up using the default of only
returning opened review requests, excluding any closed ones, regressing
the ability to match those in the quick search results.

This changes that query to not limit results to open review requests,
and adds unit tests to ensure this doesn't regress.

Unit tests pass. They failed prior to the fix.

David Trowbridge
  1. Ship It!
Christian Hammond
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (08fdb38)