Summary

Add capability flags for Git symlinks and JSON patching to the API.

Review Request #9420 — Created Dec. 4, 2017 and submitted Dec. 5, 2017, 2:28 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

35c9314...

Reviewers

Groups

reviewboard

People

Description

Git symlinks and JSON patching are two new features that clients of the
API should be able to check for prior to use. Review Board 3.0 didn't
ship with any capabilities for this, which is something worth fixing for
3.0.1. This change adds those capabilities.

It also enhances the tests around this. Our previous capabilities tests
weren't very complete, and the rest of the server information was not
checked. The unit tests now check that the returned results from the API
exactly match what we expect, based on the server's settings and the
capabilities dictionary.

Testing Done

Saw the capabilities in the API payload.

Unit tests pass.

Issues

Description	From	Last Updated
Do we want to expand this to cover all of the capabilities (including the new ones you added)? It seems …	david	Dec. 4, 2017, 4:20 p.m.

flake8 passed.

JSHint passed.

reviewboard/webapi/tests/test_server_info.py (Diff revision 1)

The issue has been resolved. Show all issues

Do we want to expand this to cover all of the capabilities (including the new ones you added)? It seems like we should either do all of them or none of them instead of a patchwork.

chipx86 Dec. 4, 2017, 3:56 p.m.

Yeah, I wasn't honestly sure what to do here. We're basically testing hard-coded keys in a data structure. I figured i'd just add a few things and punt a decision on the rest until later :P

chipx86 Dec. 4, 2017, 3:56 p.m.

An option is just to compare the data structure directly, to make sure it's been serialized by the API.

david Dec. 4, 2017, 4 p.m.
```
That's what I was about to suggest.
```

Change Summary:

Expanded the testing to more thoroughly check the results of the server info.

Description:

		Git symlinks and JSON patching are two new features that clients of the
		API should be able to check for prior to use. Review Board 3.0 didn't
		ship with any capabilities for this, which is something worth fixing for
~		3.0.1. This change simply adds those capabilities.
	~	3.0.1. This change adds those capabilities.
	+
	+	It also enhances the tests around this. Our previous capabilities tests
	+	weren't very complete, and the rest of the server information was not
	+	checked. The unit tests now check that the returned results from the API
	+	exactly match what we expect, based on the server's settings and the
	+	capabilities dictionary.

Commit:

-	c0516cec4a06450a18e8267f830dfed2d8c67a2e
+	35c93144e8a5c019c4b5073b558e05cfee0d7921

Diff:

Revision 2 (+45 -19)

Show changes

	reviewboard/webapi/server_info.py
	reviewboard/webapi/tests/test_server_info.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (56054de)