Implement guessing for submitted-revision posting in SVN

Review Request #9413 — Created Nov. 30, 2017 and discarded

GrahamS
RBTools
master
rbtools, students

Added support for guessing submitted revision posting in SVN. The summary and
description of a review request are populated with the commit message from a
submitted revision in SVN.

Manual Testing done.

Added unit test

ran nosetests -v; all tests passed.

  • 0
  • 0
  • 7
  • 0
  • 7
Description From Last Updated
  1. 
      
  2. rbtools/clients/svn.py (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     

    Setting commit = '' twice seems redundant here, but I might be missing something.

  3. 
      
  1. 
      
  2. rbtools/clients/svn.py (Diff revision 3)
     
     

    Single quote '--rbtools-working-copy'

  3. 
      
  1. 
      
  2. rbtools/clients/tests/test_svn.py (Diff revision 3)
     
     
     

    Might be better to use self.assertIn(collection, value) just so the purpose of the assertions are a bit more clear.

    ... I only mention it because Barret gave me some issues in the past for the same thing. :P

  3. 
      
  1. 
      
  2. rbtools/clients/tests/test_svn.py (Diff revision 3)
     
     

    Similarly, I believe here you can also use self.assertIsNone(commit)

  3. 
      
david
  1. 
      
  2. rbtools/clients/svn.py (Diff revision 4)
     
     

    This should probably be:

    if (revisions['tip'] != SVNClient.REVISION_WORKING_COPY and
        not revisions['tip'].startswith(
            SVNClient.REVISION_CHANGELIST_PREFIX)):
    
  3. rbtools/clients/tests/test_svn.py (Diff revision 4)
     
     

    A couple small changes in here:

    desc -> description
    commited -> committed

  4. rbtools/clients/tests/test_svn.py (Diff revision 4)
     
     
     
     
     

    Can we add some blank lines in here to break things up? Or even split these two into separate test cases?

  5. 
      
david
Review request changed

Status: Discarded

Change Summary:

Discarded in favor of https://reviews.reviewboard.org/r/9478/

Loading...