Implement guessing for submitted-revision posting in SVN

Review Request #9413 - Created Dec. 1, 2017 and updated

Graham Sea
RBTools
master
aed4ad9...
rbtools, students

Added support for guessing submitted revision posting in SVN. The summary and
description of a review request are populated with the commit message from a
submitted revision in SVN.

Manual Testing done.

Added unit test

ran nosetests -v; all tests passed.

  • 3
  • 0
  • 4
  • 0
  • 7
Description From Last Updated
This should probably be: if (revisions['tip'] != SVNClient.REVISION_WORKING_COPY and not revisions['tip'].startswith( SVNClient.REVISION_CHANGELIST_PREFIX)): David Trowbridge David Trowbridge
A couple small changes in here: desc -> description commited -> committed David Trowbridge David Trowbridge
Can we add some blank lines in here to break things up? Or even split these two into separate test ... David Trowbridge David Trowbridge
Graham Sea
Riley Creaghan
  1. 
      
  2. rbtools/clients/svn.py (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     

    Setting commit = '' twice seems redundant here, but I might be missing something.

  3. 
      
Graham Sea
Theodore Brockman
  1. 
      
  2. rbtools/clients/svn.py (Diff revision 3)
     
     

    Single quote '--rbtools-working-copy'

  3. 
      
Theodore Brockman
  1. 
      
  2. rbtools/clients/tests/test_svn.py (Diff revision 3)
     
     
     

    Might be better to use self.assertIn(collection, value) just so the purpose of the assertions are a bit more clear.

    ... I only mention it because Barret gave me some issues in the past for the same thing. :P

  3. 
      
Theodore Brockman
  1. 
      
  2. rbtools/clients/tests/test_svn.py (Diff revision 3)
     
     

    Similarly, I believe here you can also use self.assertIsNone(commit)

  3. 
      
Graham Sea
Review request changed

Change Summary:

Syntax changes to be more clear, based on Theodore's insightful review

Commit:

-48d6114c91700741d538b1759a384488506279f5
+aed4ad9be8ac19cb77dd519726f723a3d94bc2ac

Diff:

Revision 4 (+37)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
David Trowbridge
  1. 
      
  2. rbtools/clients/svn.py (Diff revision 4)
     
     

    This should probably be:

    if (revisions['tip'] != SVNClient.REVISION_WORKING_COPY and
        not revisions['tip'].startswith(
            SVNClient.REVISION_CHANGELIST_PREFIX)):
    
  3. rbtools/clients/tests/test_svn.py (Diff revision 4)
     
     

    A couple small changes in here:

    desc -> description
    commited -> committed

  4. rbtools/clients/tests/test_svn.py (Diff revision 4)
     
     
     
     
     

    Can we add some blank lines in here to break things up? Or even split these two into separate test cases?

  5. 
      
Loading...