[WIP] Code and Documentation Linking

Review Request #9401 — Created Nov. 26, 2017 and discarded

Information

Review Board
master

Reviewers

  • Create template tags for wrapping code references
  • Added CodeInspectorInfoboxView with dummy URL.
  • Configured DiffReviewableView to manage/create CodeInspectorInfoboxViews
  • Code Inspector Infobox mockup using temporary API.
  • Implement CodeInspector base classes
  • Implement Pygments Lexer code inspector

 
Description From Last Updated

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E126 continuation line over-indented for hanging indent

reviewbotreviewbot

E126 continuation line over-indented for hanging indent

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E501 line too long (109 > 79 characters)

reviewbotreviewbot

E265 block comment should start with '# '

reviewbotreviewbot

New files should include module docstrings at the top (like """Base for code inspector backends""")

giuliacmgiuliacm

W391 blank line at end of file

reviewbotreviewbot

Module docstring for new file.

giuliacmgiuliacm

Class docstring.

giuliacmgiuliacm

Module docstring for new file.

giuliacmgiuliacm

Class docstring.

giuliacmgiuliacm

E126 continuation line over-indented for hanging indent

reviewbotreviewbot

E126 continuation line over-indented for hanging indent

reviewbotreviewbot

Module docstring for new file.

giuliacmgiuliacm

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

F401 'traceback' imported but unused

reviewbotreviewbot

F401 'reviewboard.codeinspector.pygments_lexer_code_inspector_backend.PygmentsLexerCodeInspectorBackend' imported but unused

reviewbotreviewbot

E501 line too long (109 > 79 characters)

reviewbotreviewbot

E501 line too long (85 > 79 characters)

reviewbotreviewbot

E702 multiple statements on one line (semicolon)

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

Module dosctring for new file.

giuliacmgiuliacm

Don't need a space here.

giuliacmgiuliacm

This should be alphabetically sorted with the other imports.

giuliacmgiuliacm

E265 block comment should start with '# '

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

SL
Review request changed
Description:
~  
  • Added CodeInspectorInfoboxView with dummy URL.
~  
  • Configured DiffReviewableView to manage/create CodeInspectorInfoboxViews
~  
  • Code Inspector Infobox mockup using temporary API.
~  
  • Implement CodeInspector base classes
~  
  • Implement Pygments Lexer code inspector
  ~
  • Create template tags for wrapping code references
  ~
  • Added CodeInspectorInfoboxView with dummy URL.
  ~
  • Configured DiffReviewableView to manage/create CodeInspectorInfoboxViews
  ~
  • Code Inspector Infobox mockup using temporary API.
  ~
  • Implement CodeInspector base classes
  +
  • Implement Pygments Lexer code inspector
Commit:
1c679d87876b44e4f5822202eb4878829886bbd2
3499ecfd1e2e4b92a206a47c9c1494117f72227c

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

giuliacm
  1. 
      
  2. Show all issues

    New files should include module docstrings at the top (like """Base for code inspector backends""")

  3. Show all issues

    Module docstring for new file.

  4. Show all issues

    Class docstring.

  5. Show all issues

    Module docstring for new file.

  6. Show all issues

    Class docstring.

  7. reviewboard/codeinspector/views.py (Diff revision 2)
     
     
    Show all issues

    Module docstring for new file.

  8. Show all issues

    Module dosctring for new file.

  9. Show all issues

    Don't need a space here.

  10. Show all issues

    This should be alphabetically sorted with the other imports.

  11. 
      
david
Review request changed
Status:
Discarded