[WIP] Code and Documentation Linking

Review Request #9401 — Created Nov. 26, 2017 and discarded

Information

Review Board
master

Reviewers

  • Create template tags for wrapping code references
  • Added CodeInspectorInfoboxView with dummy URL.
  • Configured DiffReviewableView to manage/create CodeInspectorInfoboxViews
  • Code Inspector Infobox mockup using temporary API.
  • Implement CodeInspector base classes
  • Implement Pygments Lexer code inspector

 
Description From Last Updated

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E126 continuation line over-indented for hanging indent

reviewbotreviewbot

E126 continuation line over-indented for hanging indent

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E501 line too long (109 > 79 characters)

reviewbotreviewbot

E265 block comment should start with '# '

reviewbotreviewbot

New files should include module docstrings at the top (like """Base for code inspector backends""")

giuliacmgiuliacm

W391 blank line at end of file

reviewbotreviewbot

Module docstring for new file.

giuliacmgiuliacm

Class docstring.

giuliacmgiuliacm

Module docstring for new file.

giuliacmgiuliacm

Class docstring.

giuliacmgiuliacm

E126 continuation line over-indented for hanging indent

reviewbotreviewbot

E126 continuation line over-indented for hanging indent

reviewbotreviewbot

Module docstring for new file.

giuliacmgiuliacm

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

F401 'traceback' imported but unused

reviewbotreviewbot

F401 'reviewboard.codeinspector.pygments_lexer_code_inspector_backend.PygmentsLexerCodeInspectorBackend' imported but unused

reviewbotreviewbot

E501 line too long (109 > 79 characters)

reviewbotreviewbot

E501 line too long (85 > 79 characters)

reviewbotreviewbot

E702 multiple statements on one line (semicolon)

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

Module dosctring for new file.

giuliacmgiuliacm

Don't need a space here.

giuliacmgiuliacm

This should be alphabetically sorted with the other imports.

giuliacmgiuliacm

E265 block comment should start with '# '

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

SL
Review request changed

Description:

~  
  • Added CodeInspectorInfoboxView with dummy URL.
~  
  • Configured DiffReviewableView to manage/create CodeInspectorInfoboxViews
~  
  • Code Inspector Infobox mockup using temporary API.
~  
  • Implement CodeInspector base classes
~  
  • Implement Pygments Lexer code inspector
  ~
  • Create template tags for wrapping code references
  ~
  • Added CodeInspectorInfoboxView with dummy URL.
  ~
  • Configured DiffReviewableView to manage/create CodeInspectorInfoboxViews
  ~
  • Code Inspector Infobox mockup using temporary API.
  ~
  • Implement CodeInspector base classes
  +
  • Implement Pygments Lexer code inspector

Commit:

-1c679d87876b44e4f5822202eb4878829886bbd2
+3499ecfd1e2e4b92a206a47c9c1494117f72227c

Diff:

Revision 2 (+705 -4)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

giuliacm
  1. 
      
  2. New files should include module docstrings at the top (like """Base for code inspector backends""")

  3. Module docstring for new file.

  4. Module docstring for new file.

  5. reviewboard/codeinspector/views.py (Diff revision 2)
     
     

    Module docstring for new file.

  6. Module dosctring for new file.

  7. Don't need a space here.

  8. This should be alphabetically sorted with the other imports.

  9. 
      
david
Review request changed

Status: Discarded

Loading...