[WIP] Code and Documentation Linking

Review Request #9401 - Created Nov. 26, 2017 and updated

Shawn Lamothe
Review Board
master
3499ecf...
reviewboard, students
  • Create template tags for wrapping code references
  • Added CodeInspectorInfoboxView with dummy URL.
  • Configured DiffReviewableView to manage/create CodeInspectorInfoboxViews
  • Code Inspector Infobox mockup using temporary API.
  • Implement CodeInspector base classes
  • Implement Pygments Lexer code inspector


  • 48
  • 0
  • 0
  • 0
  • 48
Description From Last Updated
E128 continuation line under-indented for visual indent Review Bot Review Bot
E126 continuation line over-indented for hanging indent Review Bot Review Bot
E126 continuation line over-indented for hanging indent Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E501 line too long (109 > 79 characters) Review Bot Review Bot
E265 block comment should start with '# ' Review Bot Review Bot
New files should include module docstrings at the top (like """Base for code inspector backends""") Giulia Mattia Giulia Mattia
W391 blank line at end of file Review Bot Review Bot
Module docstring for new file. Giulia Mattia Giulia Mattia
Class docstring. Giulia Mattia Giulia Mattia
Module docstring for new file. Giulia Mattia Giulia Mattia
Class docstring. Giulia Mattia Giulia Mattia
E126 continuation line over-indented for hanging indent Review Bot Review Bot
E126 continuation line over-indented for hanging indent Review Bot Review Bot
Module docstring for new file. Giulia Mattia Giulia Mattia
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
E122 continuation line missing indentation or outdented Review Bot Review Bot
F401 'traceback' imported but unused Review Bot Review Bot
F401 'reviewboard.codeinspector.pygments_lexer_code_inspector_backend.PygmentsLexerCodeInspectorBackend' imported but unused Review Bot Review Bot
E501 line too long (109 > 79 characters) Review Bot Review Bot
E501 line too long (85 > 79 characters) Review Bot Review Bot
E702 multiple statements on one line (semicolon) Review Bot Review Bot
E501 line too long (88 > 79 characters) Review Bot Review Bot
Module dosctring for new file. Giulia Mattia Giulia Mattia
Don't need a space here. Giulia Mattia Giulia Mattia
This should be alphabetically sorted with the other imports. Giulia Mattia Giulia Mattia
E265 block comment should start with '# ' Review Bot Review Bot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

Shawn Lamothe
Review request changed

Description:

~  
  • Added CodeInspectorInfoboxView with dummy URL.
~  
  • Configured DiffReviewableView to manage/create CodeInspectorInfoboxViews
~  
  • Code Inspector Infobox mockup using temporary API.
~  
  • Implement CodeInspector base classes
~  
  • Implement Pygments Lexer code inspector
  ~
  • Create template tags for wrapping code references
  ~
  • Added CodeInspectorInfoboxView with dummy URL.
  ~
  • Configured DiffReviewableView to manage/create CodeInspectorInfoboxViews
  ~
  • Code Inspector Infobox mockup using temporary API.
  ~
  • Implement CodeInspector base classes
  +
  • Implement Pygments Lexer code inspector

Commit:

-1c679d87876b44e4f5822202eb4878829886bbd2
+3499ecfd1e2e4b92a206a47c9c1494117f72227c

Diff:

Revision 2 (+705 -4)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

Giulia Mattia
  1. 
      
  2. New files should include module docstrings at the top (like """Base for code inspector backends""")

  3. Module docstring for new file.

  4. Module docstring for new file.

  5. reviewboard/codeinspector/views.py (Diff revision 2)
     
     

    Module docstring for new file.

  6. Module dosctring for new file.

  7. Don't need a space here.

  8. This should be alphabetically sorted with the other imports.

  9. 
      
Loading...