Summary

RB-Gateway now pulls before answering API requests.

Review Request #9386 — Created Nov. 18, 2017 and updated Dec. 11, 2017, 8:18 p.m.

Information

Owner

hmarceau

Repository

rb-gateway

Branch

master

Bugs

Depends On

Commit

aae574d...

Reviewers

Groups

rb-gateway, students

People

Description

Calls to Pull were added at the beginning of the following API calls:
getFile, getFileByCommit, getBranches, getCommits, getCommit.
A message was also added to the merge commits.

Testing Done

HTTPIE was used to perform each of the listed API calls. After each
request, the local repository was checked to make sure the commits
of the remote were succesffully pulled.

Issues

Description	From	Last Updated
Maybe put "mirrorURL" at the bottom of this list?	david	Dec. 10, 2017, 10:40 a.m.
Was this intended to be here?	david	Dec. 10, 2017, 10:41 a.m.
As mentioned previously, "master" is a pretty git-central concept. It would be nice if we didn't have to hard-code that …	david	Nov. 25, 2017, 11:51 a.m.
And here.	david	Nov. 25, 2017, 11:51 a.m.
And here.	david	Nov. 25, 2017, 11:51 a.m.
And here.	david	Nov. 25, 2017, 11:51 a.m.
And finally here.	david	Nov. 25, 2017, 11:51 a.m.

flake8 passed.

JSHint passed.

Description:

		Calls to `Pull` were added at the beginning of the following API calls:
~		`getFile`, `getFileByCommit`, `getBranches`, `getCommits`, `getCommit`.
	~	`getFile`, `getFileByCommit`, `getBranches`, `getCommits`, `getCommit`.
	+	A message was also added to the merge commits.

Commit:

-	6f0ae422d32706ce6025ba2d08d5423b391a1836
+	7a5d60adc743cdb5522e89b26889294be4240235

Diff:

Revision 2 (+37 -4)

Show changes

	git_repository.go
	git_repository_test.go
	routes.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	Pulling before API requests
+	RB-Gateway now pulls before answering API requests.

Fix it!

git_repository_test.go (Diff revision 2)

Show all issues

Maybe put "mirrorURL" at the bottom of this list?

hmarceau Dec. 10, 2017, 10:42 a.m.

The modifications to git_repository_test.go were not supposed to be in this Review Request.

git_repository_test.go (Diff revision 2)

Show all issues

Was this intended to be here?

hmarceau Dec. 10, 2017, 10:42 a.m.

The modifications to git_repository_test.go were not supposed to be in this Review Request.
So no that was not intended to be there.

routes.go (Diff revision 2)

Show all issues

As mentioned previously, "master" is a pretty git-central concept. It would be nice if we didn't have to hard-code that in here.

routes.go (Diff revision 2)
Show all issues
```
And here.
```
routes.go (Diff revision 2)
Show all issues
```
And here.
```
routes.go (Diff revision 2)
Show all issues
```
And here.
```
routes.go (Diff revision 2)
Show all issues
```
And finally here.
```

Commit:

-	7a5d60adc743cdb5522e89b26889294be4240235
+	aae574d050004660d631ed5dc4369126b0510c14

Diff:

Revision 3 (+18 -2)

Show changes

	git_repository.go
	routes.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.