RB-Gateway now pulls before answering API requests.

Review Request #9386 - Created Nov. 19, 2017 and updated

Henri-Philippe Marceau
rb-gateway
master
aae574d...
rb-gateway, students

Calls to Pull were added at the beginning of the following API calls:
getFile, getFileByCommit, getBranches, getCommits, getCommit.
A message was also added to the merge commits.

HTTPIE was used to perform each of the listed API calls. After each
request, the local repository was checked to make sure the commits
of the remote were succesffully pulled.

  • 5
  • 0
  • 0
  • 2
  • 7
Description From Last Updated
As mentioned previously, "master" is a pretty git-central concept. It would be nice if we didn't have to hard-code that ... David Trowbridge David Trowbridge
And here. David Trowbridge David Trowbridge
And here. David Trowbridge David Trowbridge
And here. David Trowbridge David Trowbridge
And finally here. David Trowbridge David Trowbridge
Henri-Philippe Marceau
Henri-Philippe Marceau
David Trowbridge
  1. 
      
  2. git_repository_test.go (Diff revision 2)
     
     
     
     

    Maybe put "mirrorURL" at the bottom of this list?

    1. The modifications to git_repository_test.go were not supposed to be in this Review Request.

  3. git_repository_test.go (Diff revision 2)
     
     
     
     
     
     
     
     

    Was this intended to be here?

    1. The modifications to git_repository_test.go were not supposed to be in this Review Request.
      So no that was not intended to be there.

  4. routes.go (Diff revision 2)
     
     

    As mentioned previously, "master" is a pretty git-central concept. It would be nice if we didn't have to hard-code that in here.

  5. routes.go (Diff revision 2)
     
     

    And here.

  6. routes.go (Diff revision 2)
     
     

    And here.

  7. routes.go (Diff revision 2)
     
     

    And here.

  8. routes.go (Diff revision 2)
     
     

    And finally here.

  9. 
      
Henri-Philippe Marceau
Review request changed

Commit:

-7a5d60adc743cdb5522e89b26889294be4240235
+aae574d050004660d631ed5dc4369126b0510c14

Diff:

Revision 3 (+18 -2)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
Loading...