Add an integration for Trello.

Review Request #9385 - Created Nov. 17, 2017 and updated

David Trowbridge
rbintegrations
master
f94bd7c...
rbintegrations

This change adds a new integration for linking to Trello cards from
review requests. This consists of a few pieces: the integration config
which connects to a Trello via a developer key, and a review request
field which allows people to search for and link to multiple cards.

The UI is currently fully functional, but at a later date I'd like to
make it look a bit more like the related object selector used in the
admin UI, with the search box shown above the list of selected items
(instead of swapping out the entire UI for what looks more like "tags"
inside the selectize widget).

  • Tested success and error conditions within the integration config UI.
  • Added a bunch of cards and verified that everything loaded correctly.
  • Saved the field in a variety of states.
Loading file attachments...

  • 0
  • 0
  • 12
  • 0
  • 12
Description From Last Updated
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

David Trowbridge
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

David Trowbridge
Christian Hammond
  1. 
      
  2. The one thing I realize I don't have enough of a sense of is how the non-Local Site parts will work in RBCommons. Is there any risk of accessing data from Local Sites using the non-Local Site URL here or in Asana, and can arbitrary Local Sites be plugged into the URLs to access state?

  3. I think we really need unit tests for these. In particular, anything involving Local Site/configuration/review request access and potential data leakage.

  4. This could easily be one statement.

  5. I thought this was a typo of "list" at first, and was leaving a comment about a possible missing variable in the template. Can we maybe call this items?

  6. Two blank lines.

  7. rbintegrations/trello/fields.py (Diff revision 3)
     
     
     
     

    No blank line here.

  8. rbintegrations/trello/fields.py (Diff revision 3)
     
     

    Missing a docstring.

    Also, so much of this class is the same as the one in Asana. Worth making a base class? Or is it going to diverge enough where that's not worth it?

    1. I don't know that it's going to diverge but I also don't know that this is enough to justify creating a new module somewhere.

  9. rbintegrations/trello/integration.py (Diff revision 3)
     
     
     

    Swap these.

  10. rbintegrations/trello/views.py (Diff revision 3)
     
     

    Missing period.

  11. rbintegrations/trello/views.py (Diff revision 3)
     
     

    Should use logger

  12. 
      
David Trowbridge
Review request changed
Loading...