flake8
failed.
JSHint
passed.
flake8
-
rbintegrations/trello/fields.py (Diff revision 1)
Add an integration for Trello.
Review Request #9385 — Created Nov. 17, 2017 and submitted
This change adds a new integration for linking to Trello cards from
review requests. This consists of a few pieces: the integration config
which connects to a Trello via a developer key, and a review request
field which allows people to search for and link to multiple cards.The UI is currently fully functional, but at a later date I'd like to
make it look a bit more like the related object selector used in the
admin UI, with the search box shown above the list of selected items
(instead of swapping out the entire UI for what looks more like "tags"
inside the selectize widget).
- Tested success and error conditions within the integration config UI.
- Added a bunch of cards and verified that everything loaded correctly.
- Saved the field in a variety of states.
| Description | From | Last Updated |
|---|---|---|
|
The one thing I realize I don't have enough of a sense of is how the non-Local Site parts will … |
 chipx86
|
|
|
I think we really need unit tests for these. In particular, anything involving Local Site/configuration/review request access and potential data … |
chipx86
|
|
|
F401 'json' imported but unused |
 reviewbot
|
|
|
F401 'django.utils.six.moves.urllib.error.HTTPError' imported but unused |
reviewbot
|
|
|
This could easily be one statement. |
chipx86
|
|
|
I thought this was a typo of "list" at first, and was leaving a comment about a possible missing variable … |
chipx86
|
|
|
Two blank lines. |
chipx86
|
|
|
No blank line here. |
chipx86
|
|
|
Missing a docstring. Also, so much of this class is the same as the one in Asana. Worth making a … |
chipx86
|
|
|
Swap these. |
chipx86
|
|
|
Missing period. |
chipx86
|
|
|
Should use logger |
chipx86
|
|
|
Ordering is wrong. |
chipx86
|
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+496 -6) |
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
rbintegrations/trello/views.py (Diff revision 2) F401 'django.utils.six.moves.urllib.error.HTTPError' imported but unused
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+512 -6) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
The one thing I realize I don't have enough of a sense of is how the non-Local Site parts will work in RBCommons. Is there any risk of accessing data from Local Sites using the non-Local Site URL here or in Asana, and can arbitrary Local Sites be plugged into the URLs to access state?
-
I think we really need unit tests for these. In particular, anything involving Local Site/configuration/review request access and potential data leakage.
-
rbintegrations/static/js/trello/trelloFieldView.es6.js (Diff revision 3) This could easily be one statement.
-
rbintegrations/static/js/trello/trelloFieldView.es6.js (Diff revision 3) I thought this was a typo of "list" at first, and was leaving a comment about a possible missing variable in the template. Can we maybe call this items?
-
-
-
rbintegrations/trello/fields.py (Diff revision 3) Missing a docstring.
Also, so much of this class is the same as the one in Asana. Worth making a base class? Or is it going to diverge enough where that's not worth it?
-
-
-
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+600 -6) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.