Remove the floating spacer when deleting the floating banner.

Review Request #9368 — Created Nov. 13, 2017 and submitted

Information

Review Board
release-2.5.x
b0e1395...

Reviewers

Deleting the floating banner could result in the page spacer being left
behind. We now override remove() and get rid of the spacer as part of
the DOM removal process.

Had a reply banner on the page. Scrolled down so it was floating.
Deleted the last comment to make the banner go away. Previously, there
would still be a spacer there, and any new banner would appear after.
After this fix, that spacer was gone.

david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (e1eb385)
Loading...