- Summary:
-
Teach post-review GitClient to be flexiblepost-review: teach GitClient to be flexible
post-review: teach GitClient to be flexible
Review Request #935 — Created July 26, 2009 and discarded
MOVED TO http://reviews.review-board.org/r/985/ This adds more robust support for git to post-review, so now I'll actually start using it myself. You should now be able to provide any arbitrary diff for review as long as you don't do something crazy like modify your local upstream to not match the remote. * Add --upstream option to select the upstream repository, instead of hard-coding origin (origin is default) * Remove all references to master branch. We now diff against the remote name * diff_between_revisions is implemented * git-svn now diffs against git-svn remote (equivalent to upstream in pure git) instead of 'master' I don't use git-svn much, so someone with more experience should test this out. I also noticed after the fact that there are several related changes under review: http://reviews.review-board.org/r/793/ http://reviews.review-board.org/r/889/
Manual testing: * post-review with no options * post-review with --upstream specified * post-review with --parent specified * post-review with --revision-range specified * Posted this diff with this version :)
- Change Summary:
-
Fixed make_svn_diff() to not hard-code 'master'
- Description:
-
This adds more robust support for git to post-review, so now I'll actually start using it myself. You should now be able to provide any arbitrary diff for review as long as you don't do something crazy like modify your local upstream to not match the remote.
- Add --upstream option to select the upstream repository, instead of hard-coding origin (origin is default)
- Remove all references to master branch. We now diff against the remote name
- diff_between_revisions is implemented
- git-svn now diffs against git-svn remote (equivalent to upstream in pure git) instead of 'master'
+ + I don't use git-svn much, so someone with more experience should test this out. I also noticed after the fact that there are several related changes under review:
+ http://reviews.review-board.org/r/793/ + http://reviews.review-board.org/r/889/ - Diff:
-
Revision 2 (+21 -10)
-
I just tested this patch, and I'm having trouble using it. I can't do a git diff between "origin" (in the plain git case) or "git-svn" (in the git-svn) case and anything else. Git complains: fatal: ambiguous argument 'origin': unknown revision or path not in the working tree. Use '--' to separate paths from revisions
- Change Summary:
-
close out
- Description:
-
+ MOVED TO http://reviews.review-board.org/r/985/
+ + + This adds more robust support for git to post-review, so now I'll actually start using it myself. You should now be able to provide any arbitrary diff for review as long as you don't do something crazy like modify your local upstream to not match the remote.
- Add --upstream option to select the upstream repository, instead of hard-coding origin (origin is default)
- Remove all references to master branch. We now diff against the remote name
- diff_between_revisions is implemented
- git-svn now diffs against git-svn remote (equivalent to upstream in pure git) instead of 'master'
I don't use git-svn much, so someone with more experience should test this out. I also noticed after the fact that there are several related changes under review:
http://reviews.review-board.org/r/793/ http://reviews.review-board.org/r/889/