Summary

Accept input attributes in any order in unit tests.

Review Request #9344 — Created Nov. 1, 2017 and submitted Nov. 22, 2017, 1:58 p.m.

Information

Owner

erijo

Repository

Djblets

Branch

release-0.10.x

Bugs

4594

Depends On

Commit

8ad0bc3...

Reviewers

Groups

djblets

People

Description

The condition set view tests verified that input tags had the expected
type and name attributes by comparing the generated HTML. But in some
browsers the name attribute appears before the type which failed the
test.

Check the tag name and attributes individually instead.

Testing Done

Unit tests now pass.

Issues

Description	From	Last Updated
Why not just test the attributes directly? e.g. let $input = $value.find('input'); expect($input.parent.prop('tagName')).toBe('span'); expect($input.attr('type')).toBe('text'); expect($input.attr('name')).toBe('my_conditions_value[0]'));	brennie	Nov. 2, 2017, 12:08 p.m.
This can be const instead of let.	david	Nov. 3, 2017, 11:54 a.m.

flake8 passed.

JSHint passed.

djblets/static/djblets/js/forms/views/tests/conditionSetViewTests.es6.js (Diff revision 1)

Show all issues

Why not just test the attributes directly? e.g.

let $input = $value.find('input');
expect($input.parent.prop('tagName')).toBe('span');
expect($input.attr('type')).toBe('text');
expect($input.attr('name')).toBe('my_conditions_value[0]'));

Change Summary:

Update according to Barrent's comment.

Description:

		The condition set view tests verified that input tags had the expected
		type and name attributes by comparing the generated HTML. But in some
		browsers the name attribute appears before the type which failed the
		test.

~		Apply a simple regex replace to correct the order by putting type
	~	Check the tag name and attributes individually instead.
-		first and have the tests pass.