Fix a handful of unit test regressions.

Review Request #9329 — Created Oct. 26, 2017 and submitted

Information

Review Board
release-3.0.x
d3b1de7...

Reviewers

This fixes some Python and JavaScript unit tests caused by some recent
changes (and prepares fixes needed by a new version of kgb that's coming
up).

The JavaScript tests for the Review Dialog now checks for "Add General
Comment" instead of "Add Comment".

In Python, a few spies were using bad function signatures, which will
break in kgb soon. They've been fixed to use proper function signatures
that match the original function's requirements.

And finally, a bad assumption in the new e-mail hook compatibility code
where a variable was expected to not be None has been fixed. The
e-mail hook tests are all still broken right now, due to the usage of
getargspec() with spies, but the new kgb will fix those through some
new function introspection support.

Unit tests pass (using the new kgb).

david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (81237d5)
Loading...