Summary

A mirror URL can now be defined for git repositories in rb-gateway.

Review Request #9305 — Created Oct. 21, 2017 and updated Dec. 11, 2017, 8:11 p.m.

Information

Owner

hmarceau

Repository

rb-gateway

Branch

master

Bugs

Depends On

Commit

0282c75...

Reviewers

Groups

rb-gateway, students

People

Description

A Mirror string field was added to Repository Info and a GetMirror

method was implemented in git_repository.go. LoadConfig was modified

to handle the new mirror option, and a getMirror function was added to

routes.go.

Testing Done

httpie was used to send a getMirror API request to an rb-gateway
server. The plain text stored in Mirror was obtained if it was defined,
otherwise a "Mirror not defined" message is obtained.

Issues

Description	From	Last Updated
Can we add a unit test for the mirror route?	david	Dec. 10, 2017, 5:57 p.m.

flake8 passed.

JSHint passed.

Description:

~		I've added a field `Mirror string` in the `GitRepository struct`
~		and in the `Repo struct`. I need to test to see if Go and Json work
~		the way I think they do.
	~	Added `Mirror string` to `Repository Info` and a `GetMirror` signature to
	~	`repositroy.go`.
	~	Implemented `GetMirror` in `git_repository.go`.
	+	I also modified `LoadConfig` to handle the new mirror option and added a
	+	`getMirror` function to `routes.go`. `getMirror` works, I was able to define
	+	a mirror in config.json and retrieve it.

Commit:

-	083edb98159313858d9190536f4341757f209dfe
+	ba771f36321f1c465e38ff9b944a56f2b0054fa6

Diff:

Revision 2 (+47 -6)

Show changes

	git_repository.go
	repository.go
	routes.go
	util.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commit:

-	ba771f36321f1c465e38ff9b944a56f2b0054fa6
+	a6fdde509d627b75d28a5453ee9d83549842dbcf

Diff:

Revision 3 (+49 -6)

Show changes

	git_repository.go
	repository.go
	routes.go
	util.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	[WIP] Adding the Mirror_URL option
+	Adding the Mirror_URL option

Description:

~		Added `Mirror string` to `Repository Info` and a `GetMirror` signature to
~		`repositroy.go`.
~		Implemented `GetMirror` in `git_repository.go`.
~		I also modified `LoadConfig` to handle the new mirror option and added a
	~	A `Mirror string` field was added to `Repository Info` and a `GetMirror`
	~	method was implemented in `git_repository.go`. `LoadConfig` was modified
	~	to handle the new mirror option, and a `getMirror` function was added to
	~	`routes.go`.
-		`getMirror` function to `routes.go`. `getMirror` works, I was able to define
-		a mirror in config.json and retrieve it.

Testing Done:

	+	`httpie` was used to send a `getMirror` API request to an rb-gateway
	+	server. The plain text stored in `Mirror` was obtained if it was defined,
	+	otherwise a `"Mirror not defined"` message is obtained.

Summary:

-	Adding the Mirror_URL option
+	A mirror URL can now be defined for git repositories in rb-gateway.

Show all issues

Can we add a unit test for the mirror route?

hmarceau Dec. 10, 2017, 5:59 p.m.

The tests can be found in Review Request 9435.
https://reviews.reviewboard.org/r/9435/

Commit:

-	a6fdde509d627b75d28a5453ee9d83549842dbcf
+	0282c759e241e70e21a4e2656025923d758df0e5

Diff:

Revision 4 (+49 -6)

Show changes

	git_repository.go
	repository.go
	routes.go
	util.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.