Indication that SCM change is pending. (Issue 1230)

Review Request #930 - Created July 22, 2009 and submitted

Nathan Auch
Review Board SVN (deprecated)
reviewboard
Address issue 1230 in the Review Board issue tracker. Add an indication when the SCM changeset associated with a review request is pending. Currently only implemented for Perforce.


Christian Hammond
  1. 
      
  2. /trunk/reviewboard/reviews/models.py (Diff revision 1)
     
     
    I'd prefer changeset_is_pending.
  3. /trunk/reviewboard/reviews/models.py (Diff revision 1)
     
     
    changeset, not changset
  4. /trunk/reviewboard/reviews/models.py (Diff revision 1)
     
     
     
    Trailing whitespace.
  5. /trunk/reviewboard/reviews/models.py (Diff revision 1)
     
     
    This shouldn't be executed if we don't have a changenum.
  6. /trunk/reviewboard/scmtools/core.py (Diff revision 1)
     
     
     
     
     
    Should remain two blank lines.
  7. /trunk/reviewboard/scmtools/perforce.py (Diff revision 1)
     
     
    Should use spaces only for indentation. Make sure this is the case throughout the entire change.
  8. Needs translation.
    1. I wrapped (pending) in a {% trans %} tag. Is there anything else I need to do for translation?
  9. 
      
Nathan Auch
Nathan Auch
Nathan Auch
Review request changed
Christian Hammond
  1. Thanks Nathan. Committed to master as r61dcc3d.
  2. 
      
Loading...