Summary:

Indication that SCM change is pending. (Issue 1230)

Review Request #930 — Created July 22, 2009 and submitted

Information
Owner:	nathan.auch
Repository:	Review Board SVN (deprecated)
Branch:
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

Address issue 1230 in the Review Board issue tracker. Add an indication when the SCM changeset associated with a review request is pending. Currently only implemented for Perforce.

Testing Done

/trunk/reviewboard/reviews/models.py (Diff revision 1)
```
I'd prefer changeset_is_pending.
```
1. NA
  
  nathan.auch July 22, 2009, 4:50 a.m.
  done
/trunk/reviewboard/reviews/models.py (Diff revision 1)
```
changeset, not changset
```
1. NA
  
  nathan.auch July 22, 2009, 4:50 a.m.
  done
/trunk/reviewboard/reviews/models.py (Diff revision 1)
```
Trailing whitespace.
```
1. NA
  
  nathan.auch July 22, 2009, 4:50 a.m.
  done
/trunk/reviewboard/reviews/models.py (Diff revision 1)
```
This shouldn't be executed if we don't have a changenum.
```
1. NA
  
  nathan.auch July 22, 2009, 4:50 a.m.
  done
/trunk/reviewboard/scmtools/core.py (Diff revision 1)
```
Should remain two blank lines.
```
1. NA
  
  nathan.auch July 22, 2009, 4:50 a.m.
  done

/trunk/reviewboard/scmtools/perforce.py (Diff revision 1)

Should use spaces only for indentation. Make sure this is the case throughout the entire change.

NA

nathan.auch July 22, 2009, 4:50 a.m.
```
done
```

/trunk/reviewboard/templates/reviews/review_request_box.html (Diff revision 1)

Needs translation.

nathan.auch July 22, 2009, 4:51 a.m.

I wrapped (pending) in a {% trans %} tag. Is there anything else I need to do for translation?

Change Summary:

Made requested changes.

Diff:

Revision 2 (+15 -2)

Show changes

	/trunk/reviewboard/reviews/models.py
	/trunk/reviewboard/scmtools/core.py
	/trunk/reviewboard/scmtools/perforce.py
	/trunk/reviewboard/templates/reviews/review_request_box.html

Change Summary:

Don't cause an error if we try to query the status of an empty changeset (because all files were reverted after the review request was initially submitted).

Diff:

Revision 3 (+19 -3)

Show changes

	/trunk/reviewboard/reviews/models.py
	/trunk/reviewboard/scmtools/core.py
	/trunk/reviewboard/scmtools/perforce.py
	/trunk/reviewboard/templates/reviews/review_request_box.html

Change Summary:

Previous change (diff 3) made it possible to reference an undefined variable.

Diff:

Revision 4 (+18 -3)

Show changes

	/trunk/reviewboard/reviews/models.py
	/trunk/reviewboard/scmtools/core.py
	/trunk/reviewboard/scmtools/perforce.py
	/trunk/reviewboard/templates/reviews/review_request_box.html

Ship it!

Thanks Nathan. Committed to master as r61dcc3d.