Add documentation for custom review request fields.




 


  Review Request #9298
  —
  Created Oct. 20, 2017 and submitted 

 















 
  
  
 




 
  

   Information

  

 
 

  

   
   
david


  


  

   
   
Review Board


  


  

   
   
release-3.0.x


  


  

   
   



  


  

   
   



  


  

   
   
9310


  


  

   
   
2bd3a68...


  


 



 
  

   Reviewers

  

 
 

  

   
   
reviewboard


  


  

   
   



  


 











 

  
  


This change adds some more complete documentation for adding new review request

fields, which is likely to be a very common use case for extensions.




 




 

  
  


Built HTML and looked through the output.




 














 

 






 
 
 

  

   

    
   

   
    
    
  • 
     
    
    • 
    
  • 
     
    
    • 
    
  • 
     
    
    • 
    
  • 
     
    
    • 
    
  • 
     
    
    • 
   

  

  

   
    

     Description
     From
     Last Updated
    

   
   



    

     
      
      
This looks great. It would be nice to show sample usage for each of the built-in types, though, to help …

     		
     
      chipx86chipx86
     
     
      
     
    




    

     
      
      
You can use :js:class: here.

     		
     
      chipx86chipx86
     
     
      
     
    




    

     
      
      
Should be in Title Casing.

     		
     
      chipx86chipx86
     
     
      
     
    




    

     
      
      
Can we link these to the definitions on the base class?

     		
     
      chipx86chipx86
     
     
      
     
    


   
  

 












  

 



















 




 




 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    This looks great. It would be nice to show sample usage for each of the built-in types, though, to help cut back on questions or problems as people go to play with these. Ideally, we'd have a small section on the usage for each of these.
    

    Also ideally, we'd have a section on crafting a completely custom field, since that's probably going to come up somewhere. Maybe less beneficial compared to the sample usages for the built-in types, but would be good to have.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      There are so many directions that a completely custom field might go in that I'm not sure a sample is really that useful. That said, the example with selectize is probably a good enough start for anyone who actually has the skills to do something crazy.
      
 
      

      2. 


 
    


    

 
    

    3. 















  3. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    You can use :js:class: here.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Should be in Title Casing.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 






  5. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Can we link these to the definitions on the base class?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 




  6. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    7. 




  

 
















 



 

  

   




david




   

   

  

 



 















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-3.0.x (e1a23c0)





 


 










  

 









     

    

   

  

  

   
   Loading...