flake8
passed.
JSHint
passed.
Add documentation for custom review request fields.
Review Request #9298 — Created Oct. 20, 2017 and submitted
This change adds some more complete documentation for adding new review request
fields, which is likely to be a very common use case for extensions.
Built HTML and looked through the output.
-
-
This looks great. It would be nice to show sample usage for each of the built-in types, though, to help cut back on questions or problems as people go to play with these. Ideally, we'd have a small section on the usage for each of these.
Also ideally, we'd have a section on crafting a completely custom field, since that's probably going to come up somewhere. Maybe less beneficial compared to the sample usages for the built-in types, but would be good to have.
-
docs/manual/extending/extensions/review-request-fields.rst (Diff revision 1) You can use
:js:class:here. -
docs/manual/extending/extensions/review-request-fields.rst (Diff revision 1) Should be in Title Casing.
-
docs/manual/extending/extensions/review-request-fields.rst (Diff revision 1) Can we link these to the definitions on the base class?
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+188 -12) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.