flake8
passed.
JSHint
passed.
Flesh out the documentation on Ship It-related functionality.
Review Request #9295 — Created Oct. 19, 2017 and submitted
Our documentation on marking reviews with Ship It! was a bit stale and
didn't cover some of the modern features of approval. It's been
rewritten to better cover the methods for marking Ship It!, what a
"Fix It, then Ship It!" review means, and how to revoke a Ship It!. This
all comes with screenshots, helping to give people a visual on what this
all looks like.
Built the docs and read through them. Checked for build failures and
spelling errors.Made sure the normal and high-res images aligned properly when
transitioning without causing any visual jump.
-
-
docs/manual/users/reviews/approving-changes.rst (Diff revision 1) I think this was meant to say "ways of filing"
-
docs/manual/users/reviews/approving-changes.rst (Diff revision 1) Should maybe say that they can fill in the "Header" box with their comments here.
Change Summary:
- Added a missing word.
- Expanded the section on using the Review Dialog to mark Ship It to talk about filling out the Header field, and to transition nicely to the "Fix It, then Ship It!" section.
- Added anchor points to each section so other docs can better link to them.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+85 -14) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.