flake8
passed.
JSHint
failed.
JSHint
-
reviewboard/static/rb/js/diffviewer/views/diffFileIndexView.js (Diff revision 1) Show all issues
[WIP] Mobile diff viewer project
Review Request #9266 — Created Oct. 13, 2017 and discarded
| Information | |
|---|---|
| tbrockma | |
| Review Board | |
| master | |
| Reviewers | |
| reviewboard, students | |
wip don't look here
| Description | From | Last Updated |
|---|---|---|
|
Col: 10 Missing semicolon. |
 reviewbot
|
|
|
Col: 10 Missing semicolon. |
reviewbot
|
|
|
Col: 10 Missing semicolon. |
reviewbot
|
|
|
Col: 32 Expected '!==' and instead saw '!='. |
reviewbot
|
|
|
Col: 13 Expected '{' and instead saw 'target'. |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
F841 local variable 'cell_classes' is assigned to but never used |
reviewbot
|
|
|
F841 local variable 'cell_class_attr' is assigned to but never used |
reviewbot
|
|
|
It looks like you've got some stuff from your easyfix branch leaking into this. |
 david
|
TB
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+351 -67) |
Checks run (1 failed, 1 succeeded)
flake8
passed.
JSHint
failed.
JSHint
-
reviewboard/static/rb/js/diffviewer/views/diffFileIndexView.js (Diff revision 2) Col: 10 Missing semicolon.
TB
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+387 -75) |
Checks run (1 failed, 1 succeeded)
flake8
passed.
JSHint
failed.
JSHint
-
reviewboard/static/rb/js/diffviewer/views/diffFileIndexView.js (Diff revision 3) Col: 10 Missing semicolon.
TB
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+387 -75) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
TB
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 5 (+413 -85) |
Checks run (1 failed, 1 succeeded)
flake8
passed.
JSHint
failed.
JSHint
-
reviewboard/static/rb/js/diffviewer/views/diffFileIndexView.js (Diff revision 5) Col: 32 Expected '!==' and instead saw '!='.
-
reviewboard/static/rb/js/diffviewer/views/diffFileIndexView.js (Diff revision 5) Col: 13 Expected '{' and instead saw 'target'.
TB
Description: |
|
|---|
TB
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 6 (+522 -89) |
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
TB
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 7 (+1091 -114) |
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
reviewboard/diffviewer/templatetags/difftags.py (Diff revision 7) E302 expected 2 blank lines, found 1
-
reviewboard/diffviewer/templatetags/difftags.py (Diff revision 7) E501 line too long (80 > 79 characters)
-
reviewboard/diffviewer/templatetags/difftags.py (Diff revision 7) F841 local variable 'cell_classes' is assigned to but never used
-
reviewboard/diffviewer/templatetags/difftags.py (Diff revision 7) F841 local variable 'cell_class_attr' is assigned to but never used
-
It looks like you've got a bunch of different changes all kind of mixed together. Is it possible to extract things so that you have one review request per change?
-
reviewboard/webapi/resources/review_request.py (Diff revision 7) It looks like you've got some stuff from your easyfix branch leaking into this.