[WIP] Mobile diff viewer project

Review Request #9266 — Created Oct. 14, 2017 and discarded

tbrockma
Review Board
master
reviewboard, students

wip don't look here



Description From Last Updated

Col: 10 Missing semicolon.

reviewbotreviewbot

Col: 10 Missing semicolon.

reviewbotreviewbot

Col: 10 Missing semicolon.

reviewbotreviewbot

Col: 32 Expected '!==' and instead saw '!='.

reviewbotreviewbot

Col: 13 Expected '{' and instead saw 'target'.

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

F841 local variable 'cell_classes' is assigned to but never used

reviewbotreviewbot

F841 local variable 'cell_class_attr' is assigned to but never used

reviewbotreviewbot

It looks like you've got some stuff from your easyfix branch leaking into this.

daviddavid
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

TB
Review request changed
TB
Review request changed
TB
TB
Review request changed
TB
TB
Review request changed
TB
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
  1. It looks like you've got a bunch of different changes all kind of mixed together. Is it possible to extract things so that you have one review request per change?

    1. I could do that in the future, but a lot of the stuff here isn't really anything I would want to put up for review until I've fixed things and written tests for each change.

      It's a lot of hacky code just to get things working so I will definitely be putting time into cleaning everything up.

  2. It looks like you've got some stuff from your easyfix branch leaking into this.

    1. Yeah, I'm not entirely certain why that happened, they both exist in their own separate branches but I guess at some point I merged incorrectly.

  3. 
      
TB
Review request changed

Status: Discarded

Loading...