Never show the initial status updates entry as being new.

Review Request #9257 - Created Oct. 10, 2017 and submitted

Christian Hammond
Review Board
release-3.0.x
a3cd0f4...
reviewboard

The initial status updates entry on the review request page generally
will accompany the review request when first published, or will appear
shortly after as the result of a call to some external service or tool.
When first shown, it was appearing as new, with that state changing
shortly after when a status update changes. Showing this entry as new
doesn't really benefit anyone, and the jump in newness is a bit weird.
It also just wasn't useful as the newness never represented things like
new reviews from status updates.

This change forces the entry to never appear as new. Replises will
continue to appear as new as needed.

Unit tests pass.

Tested that the initial status update entry didn't appear new on
review request creation.

  • 0
  • 0
  • 3
  • 0
  • 3
Description From Last Updated
David Trowbridge
  1. 
      
  2. reviewboard/reviews/detail.py (Diff revision 1)
     
     

    As I mentioned in a comment on the test, the superclass has some required args. I think you should probably include those in the method signature here instead of just catching it with *args.

  3. reviewboard/reviews/detail.py (Diff revision 1)
     
     

    Should be *args

  4. The superclass implementation requires last_visited and user arguments. I don't think this test is particularly valuable as-written--if the new is_entry_new function didn't exist, this would crash.

  5. 
      
Christian Hammond
David Trowbridge
  1. Ship It!
  2. 
      
Christian Hammond
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (06fe639)
Loading...