Summary

Correct pre/post template hook name.

Review Request #9252 — Created Oct. 8, 2017 and submitted Oct. 18, 2017, 12:04 p.m.

Information

Owner

erijo

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

e832ad9...

Reviewers

Groups

reviewboard

People

Description

Use entry_type_id instead of entry_id (which is a number) to make the
review-summary-header-pre/post hooks work as documented and expected.

Testing Done

Tested that review-summary-header-post now does what it should.

Issues

Description	From	Last Updated
Can you expand the description a bit to describe what the problem was from a usage standpoint? I know that …	david	Oct. 8, 2017, 10:37 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Can you expand the description a bit to describe what the problem was from a usage standpoint? I know that when looking at the code it's obvious, but if someone is just reading a git log it might not be.

erijo Oct. 11, 2017, 10:18 a.m.

Is this ok David or should I rephrase it even more?

Description:

~		entry_id is a number, entry_type_id is e.g. review.
	~	Use entry_type_id instead of entry_id (which is a number) to make the review-summary-header-pre/post hooks work as documented and expected.

Summary:

-	Correct pre/post template hook name
+	Correct pre/post template hook name.

Description:

~		Use entry_type_id instead of entry_id (which is a number) to make the review-summary-header-pre/post hooks work as documented and expected.
	~	Use entry_type_id instead of entry_id (which is a number) to make the
	+	review-summary-header-pre/post hooks work as documented and expected.

Commit:

-	a759e5cf9a359affa59c118912f106b78498a289
+	e832ad997219adc04cf837a54cbfec9b13ac2720

Diff:

Revision 2 (+2 -2)

Show changes

reviewboard/templates/reviews/entries/base.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (70450cb)