Adding my reviews section to the dashboard's sidebar.

Review Request #9246 — Created Oct. 9, 2017 and discarded

Information

Review Board
master

Reviewers

When user login to Review Board dashboard, they would like
to see all their open requests from incoming and outgoing.
Therefore, adding a new section that is called 'My Reviews'
will allow users to see all their open requests.

Added a unit test, which passes (along with all other tests).

  • Created test review requests that will be open under incoming and
    outgoing sections.
  • Ran it using this command ./tests/runtests.py
    reviewboard.reviews.tests.test_review_request_manager
  • The test calls the query that merge the requests.
  • It will check if the requests are merged successfully than it passes
    the test.
Description From Last Updated

E501 line too long (118 > 79 characters)

reviewbotreviewbot

E302 expected 2 blank lines, found 0

reviewbotreviewbot

E501 line too long (118 > 79 characters)

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

It looks like your project code and your bug fix code got combined together. This shouldn't be part of this …

daviddavid

E124 closing bracket does not match visual indentation

reviewbotreviewbot

E501 line too long (118 > 79 characters)

reviewbotreviewbot

E302 expected 2 blank lines, found 0

reviewbotreviewbot

E501 line too long (118 > 79 characters)

reviewbotreviewbot

E501 line too long (122 > 79 characters)

reviewbotreviewbot

E501 line too long (118 > 79 characters)

reviewbotreviewbot

E302 expected 2 blank lines, found 0

reviewbotreviewbot

E501 line too long (118 > 79 characters)

reviewbotreviewbot

E501 line too long (122 > 79 characters)

reviewbotreviewbot

E501 line too long (125 > 79 characters)

reviewbotreviewbot

E999 IndentationError: unindent does not match any outer indentation level

reviewbotreviewbot

This isn't correct (copy/paste-o?)

daviddavid

This should have a "Yields:" section. See https://www.notion.so/reviewboard/Writing-Codebase-Documentation-e16312b5f061437cb73cbfa369ac3cb5

daviddavid

The view ID should use a hyphen rather than an underscore.

daviddavid

I suspect we want this to be the first item in the sidebar.

daviddavid

This should probably be changed to "My open outgoing review requests"

daviddavid

This should probably be changed to "All my open outgoing review requests"

daviddavid

We should change this to use sentence casing rather than title casing.

daviddavid

Can we put this as the first thing checked? The view string should also have a hyphen instead of an …

daviddavid

This should probably be "My open incoming and outgoin review requests"

daviddavid

Should change this to be sentence casing.

daviddavid

Should change this to be sentence casing.

daviddavid

Should change this to be sentence casing.

daviddavid

Should change this to be sentence casing.

daviddavid

This should probably be named get_my_reviews_query to match other, similar method names.

daviddavid

The docstring here needs "Args:" and "Returns:" sections. See https://www.notion.so/reviewboard/Writing-Codebase-Documentation-e16312b5f061437cb73cbfa369ac3cb5 for some info on these.

daviddavid

E128 continuation line under-indented for visual indent

reviewbotreviewbot

W503 line break before binary operator

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

W503 line break before binary operator

reviewbotreviewbot

This needs a docstring (I know others don't have them but they're old code).

daviddavid

Can we call the column "my_reviews_count" to match the name used elsewhere? "my review request count" sounds almost like it's …

daviddavid

W292 no newline at end of file

reviewbotreviewbot

This needs a "Yields" section.

daviddavid

typo: outgoin

daviddavid

This shouldn't include the word "open", since it's all including both open and closed.

daviddavid

This should be in the imperative mood ("Return" instead of "Returns"). This docstring also needs Args/Returns sections.

daviddavid

This needs a docstring.

daviddavid

New file should include module docstring.

giuliacmgiuliacm

Maybe add a description of what get_my_reviews_query does, and add as an additional note that it's meant to be passed …

giuliacmgiuliacm
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
  1. 
      
  2. Show all issues

    It looks like your project code and your bug fix code got combined together. This shouldn't be part of this change. If you need help untangling this, please ping @mentors in slack.

    1. I didn't notice that I didn't create branch from master. However, I decided to open a new Review Request that is #9294.

  3. 
      
MU
MU
Review request changed
Description:
~  

[Will fix it later] Adding my reviews section to the dashboard sidebar.

  ~

[Will fix it later] Adding my reviews section to the dashboard sidebar.

-   Decided to ignore this one and moved to the new Review Request #9294

Branch:
release-3.0.x
master
Commit:
8da72b57962cead36de11eac414c1b7a4d4d0259
4ac8ceb5715426c36421c76698337c5ff54e7d88

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

MU
Review request changed
Commit:
4ac8ceb5715426c36421c76698337c5ff54e7d88
6418c8a0cbee8db932ef79b7c79734e0c184621f

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

MU
Review request changed
Commit:
6418c8a0cbee8db932ef79b7c79734e0c184621f
a25c02bbb2ba1906cee78173ca9be03ee8e2a27a

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
  1. 
      
  2. reviewboard/datagrids/builtin_items.py (Diff revision 4)
     
     
     
     
     
     
     
     
    Show all issues

    This isn't correct (copy/paste-o?)

    1. I noticed that and fixed it, but didn't publish the newest-modified review request.

  3. reviewboard/datagrids/builtin_items.py (Diff revision 4)
     
     
    Show all issues

    This should have a "Yields:" section. See https://www.notion.so/reviewboard/Writing-Codebase-Documentation-e16312b5f061437cb73cbfa369ac3cb5

  4. reviewboard/datagrids/builtin_items.py (Diff revision 4)
     
     
    Show all issues

    The view ID should use a hyphen rather than an underscore.

  5. reviewboard/datagrids/grids.py (Diff revision 4)
     
     
    Show all issues

    I suspect we want this to be the first item in the sidebar.

  6. reviewboard/datagrids/grids.py (Diff revision 4)
     
     
    Show all issues

    This should probably be changed to "My open outgoing review requests"

  7. reviewboard/datagrids/grids.py (Diff revision 4)
     
     
    Show all issues

    This should probably be changed to "All my open outgoing review requests"

  8. reviewboard/datagrids/grids.py (Diff revision 4)
     
     
    Show all issues

    We should change this to use sentence casing rather than title casing.

  9. reviewboard/datagrids/grids.py (Diff revision 4)
     
     
    Show all issues

    Can we put this as the first thing checked? The view string should also have a hyphen instead of an underscore.

  10. reviewboard/datagrids/grids.py (Diff revision 4)
     
     
    Show all issues

    This should probably be "My open incoming and outgoin review requests"

  11. reviewboard/datagrids/grids.py (Diff revision 4)
     
     
    Show all issues

    Should change this to be sentence casing.

  12. reviewboard/datagrids/grids.py (Diff revision 4)
     
     
    Show all issues

    Should change this to be sentence casing.

  13. reviewboard/datagrids/grids.py (Diff revision 4)
     
     
    Show all issues

    Should change this to be sentence casing.

  14. reviewboard/datagrids/grids.py (Diff revision 4)
     
     
    Show all issues

    Should change this to be sentence casing.

  15. reviewboard/reviews/managers.py (Diff revision 4)
     
     
    Show all issues

    This should probably be named get_my_reviews_query to match other, similar method names.

  16. reviewboard/reviews/managers.py (Diff revision 4)
     
     
    Show all issues

    The docstring here needs "Args:" and "Returns:" sections. See https://www.notion.so/reviewboard/Writing-Codebase-Documentation-e16312b5f061437cb73cbfa369ac3cb5 for some info on these.

  17. reviewboard/reviews/managers.py (Diff revision 4)
     
     
    Show all issues

    This needs a docstring (I know others don't have them but they're old code).

  18. 
      
MU
MU
Review request changed
Commit:
f7fdbd0b40a71f767de6ac76fd65d23c3bf55fc9
b036a3f48566bd37f74f2f88e4a7378f0cfaed2c

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
  1. 
      
  2. reviewboard/accounts/admin.py (Diff revision 6)
     
     
    Show all issues

    Can we call the column "my_reviews_count" to match the name used elsewhere? "my review request count" sounds almost like it's the outgoing review requests.

  3. reviewboard/datagrids/builtin_items.py (Diff revision 6)
     
     
    Show all issues

    This needs a "Yields" section.

  4. reviewboard/datagrids/grids.py (Diff revision 6)
     
     
    Show all issues

    typo: outgoin

  5. reviewboard/datagrids/grids.py (Diff revision 6)
     
     
    Show all issues

    This shouldn't include the word "open", since it's all including both open and closed.

  6. reviewboard/reviews/managers.py (Diff revision 6)
     
     
    Show all issues

    This should be in the imperative mood ("Return" instead of "Returns").

    This docstring also needs Args/Returns sections.

    1. Should I also change the others to be in the imperative mood (I mean the old code)?

    2. If you want to do that in a separate change that's fine but I wouldn't include it in this.

  7. reviewboard/reviews/managers.py (Diff revision 6)
     
     
    Show all issues

    This needs a docstring.

  8. 
      
MU
MU
MU
giuliacm
  1. 
      
  2. Show all issues

    New file should include module docstring.

    1. This is only to add evolution to the DB. I don't think it needs docstring.

  3. reviewboard/reviews/managers.py (Diff revision 9)
     
     
    Show all issues

    Maybe add a description of what get_my_reviews_query does, and add as an additional note that it's meant to be passed to ReviewRequest.objects.public()

  4. 
      
MU
david
Review request changed
Status:
Discarded