Summary:

Adding my reviews section to the dashboard's sidebar.

Review Request #9246 — Created Oct. 9, 2017 and discarded Jan. 29, 2019, 1:46 p.m.

Information
Owner:	mukhtar
Repository:	Review Board
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	reviewboard, students
People:

Description

When user login to Review Board dashboard, they would like
to see all their open requests from incoming and outgoing.
Therefore, adding a new section that is called 'My Reviews'
will allow users to see all their open requests.

Testing Done

Added a unit test, which passes (along with all other tests).

Created test review requests that will be open under incoming and
outgoing sections.
Ran it using this command ./tests/runtests.py
reviewboard.reviews.tests.test_review_request_manager
The test calls the query that merge the requests.
It will check if the requests are merged successfully than it passes
the test.

Issues

Description	From	Last Updated
E501 line too long (118 > 79 characters)	reviewbot	Oct. 31, 2017, 3:16 p.m.
E302 expected 2 blank lines, found 0	reviewbot	Oct. 31, 2017, 3:19 p.m.
E501 line too long (118 > 79 characters)	reviewbot	Oct. 31, 2017, 3:16 p.m.
W291 trailing whitespace	reviewbot	Oct. 31, 2017, 3:16 p.m.
It looks like your project code and your bug fix code got combined together. This shouldn't be part of this …	david	Oct. 21, 2017, 8:19 a.m.
E124 closing bracket does not match visual indentation	reviewbot	Oct. 31, 2017, 3:20 p.m.
E501 line too long (118 > 79 characters)	reviewbot	Oct. 31, 2017, 3:18 p.m.
E302 expected 2 blank lines, found 0	reviewbot	Oct. 31, 2017, 3:19 p.m.
E501 line too long (118 > 79 characters)	reviewbot	Oct. 31, 2017, 3:18 p.m.
E501 line too long (122 > 79 characters)	reviewbot	Oct. 31, 2017, 3:18 p.m.
E501 line too long (118 > 79 characters)	reviewbot	Oct. 31, 2017, 3:18 p.m.
E302 expected 2 blank lines, found 0	reviewbot	Oct. 31, 2017, 3:19 p.m.
E501 line too long (118 > 79 characters)	reviewbot	Oct. 31, 2017, 3:17 p.m.
E501 line too long (122 > 79 characters)	reviewbot	Oct. 31, 2017, 3:17 p.m.
E501 line too long (125 > 79 characters)	reviewbot	Oct. 31, 2017, 3:17 p.m.
E999 IndentationError: unindent does not match any outer indentation level	reviewbot	Oct. 31, 2017, 3:17 p.m.
This isn't correct (copy/paste-o?)	david	Nov. 10, 2017, 3:16 p.m.
This should have a "Yields:" section. See https://www.notion.so/reviewboard/Writing-Codebase-Documentation-e16312b5f061437cb73cbfa369ac3cb5	david	Nov. 27, 2017, 4:43 p.m.
The view ID should use a hyphen rather than an underscore.	david	Nov. 10, 2017, 4:36 p.m.
I suspect we want this to be the first item in the sidebar.	david	Nov. 10, 2017, 4:37 p.m.
This should probably be changed to "My open outgoing review requests"	david	Nov. 10, 2017, 4:37 p.m.
This should probably be changed to "All my open outgoing review requests"	david	Nov. 10, 2017, 4:38 p.m.
We should change this to use sentence casing rather than title casing.	david	Nov. 10, 2017, 4:38 p.m.
Can we put this as the first thing checked? The view string should also have a hyphen instead of an …	david	Nov. 10, 2017, 4:39 p.m.
This should probably be "My open incoming and outgoin review requests"	david	Nov. 10, 2017, 4:39 p.m.
Should change this to be sentence casing.	david	Nov. 10, 2017, 4:40 p.m.
Should change this to be sentence casing.	david	Nov. 10, 2017, 4:41 p.m.
Should change this to be sentence casing.	david	Nov. 10, 2017, 4:41 p.m.
Should change this to be sentence casing.	david	Nov. 10, 2017, 4:41 p.m.
This should probably be named get_my_reviews_query to match other, similar method names.	david	Nov. 10, 2017, 4:42 p.m.
The docstring here needs "Args:" and "Returns:" sections. See https://www.notion.so/reviewboard/Writing-Codebase-Documentation-e16312b5f061437cb73cbfa369ac3cb5 for some info on these.	david	Nov. 27, 2017, 4:53 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Oct. 31, 2017, 3:30 p.m.
W503 line break before binary operator	reviewbot	Nov. 10, 2017, 3:52 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Oct. 31, 2017, 3:30 p.m.
W503 line break before binary operator	reviewbot	Nov. 10, 2017, 3:52 p.m.
This needs a docstring (I know others don't have them but they're old code).	david	Dec. 2, 2017, 7:05 a.m.
Can we call the column "my_reviews_count" to match the name used elsewhere? "my review request count" sounds almost like it's …	david	Nov. 21, 2017, 6:18 p.m.
W292 no newline at end of file	reviewbot	Nov. 10, 2017, 6:03 p.m.
This needs a "Yields" section.	david	Dec. 2, 2017, 7:08 a.m.
typo: outgoin	david	Nov. 21, 2017, 6:19 p.m.
This shouldn't include the word "open", since it's all including both open and closed.	david	Nov. 21, 2017, 6:19 p.m.
This should be in the imperative mood ("Return" instead of "Returns"). This docstring also needs Args/Returns sections.	david	Dec. 2, 2017, 7:08 a.m.
This needs a docstring.	david	Dec. 2, 2017, 7:09 a.m.
New file should include module docstring.	giuliacm	Dec. 6, 2017, 7:03 a.m.
Maybe add a description of what get_my_reviews_query does, and add as an additional note that it's meant to be passed …	giuliacm	Dec. 10, 2017, 4:55 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/datagrids/builtin_items.py (Diff revision 1)
Show all issues
```
E501 line too long (118 > 79 characters)
```
reviewboard/datagrids/builtin_items.py (Diff revision 1)
Show all issues
```
E302 expected 2 blank lines, found 0
```
reviewboard/datagrids/grids.py (Diff revision 1)
Show all issues
```
E501 line too long (118 > 79 characters)
```
reviewboard/datagrids/grids.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```
reviewboard/reviews/models/review_request_draft.py (Diff revision 1)
Show all issues
```
E124 closing bracket does not match visual indentation
```

reviewboard/reviews/models/review_request_draft.py (Diff revision 1)

Show all issues

It looks like your project code and your bug fix code got combined together. This shouldn't be part of this change. If you need help untangling this, please ping @mentors in slack.

mukhtar Oct. 19, 2017, 4:20 p.m.

I didn't notice that I didn't create branch from master. However, I decided to open a new Review Request that is #9294.

Description:

~		[Will fix it later] Adding my reviews section to the dashboard sidebar.
	~	[Will fix it later] Adding my reviews section to the dashboard sidebar.
	+	Decided to ignore this one and moved to the new Review Request #9294

Description:

~		[Will fix it later] Adding my reviews section to the dashboard sidebar.
	~	[Will fix it later] Adding my reviews section to the dashboard sidebar.
-		Decided to ignore this one and moved to the new Review Request #9294

Branch:

-	release-3.0.x
+	master

Commit:

-	8da72b57962cead36de11eac414c1b7a4d4d0259
+	4ac8ceb5715426c36421c76698337c5ff54e7d88

Diff:

Revision 2 (+29)

Show changes

	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/datagrids/builtin_items.py (Diff revision 2)
Show all issues
```
E501 line too long (118 > 79 characters)
```
reviewboard/datagrids/builtin_items.py (Diff revision 2)
Show all issues
```
E302 expected 2 blank lines, found 0
```
reviewboard/datagrids/grids.py (Diff revision 2)
Show all issues
```
E501 line too long (118 > 79 characters)
```
reviewboard/datagrids/grids.py (Diff revision 2)
Show all issues
```
E501 line too long (122 > 79 characters)
```

Commit:

-	4ac8ceb5715426c36421c76698337c5ff54e7d88
+	6418c8a0cbee8db932ef79b7c79734e0c184621f

Diff:

Revision 3 (+85)

Show changes

	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/reviews/managers.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/datagrids/builtin_items.py (Diff revision 3)
Show all issues
```
E501 line too long (118 > 79 characters)
```
reviewboard/datagrids/builtin_items.py (Diff revision 3)
Show all issues
```
E302 expected 2 blank lines, found 0
```
reviewboard/datagrids/grids.py (Diff revision 3)
Show all issues
```
E501 line too long (118 > 79 characters)
```
reviewboard/datagrids/grids.py (Diff revision 3)
Show all issues
```
E501 line too long (122 > 79 characters)
```
reviewboard/datagrids/grids.py (Diff revision 3)
Show all issues
```
E501 line too long (125 > 79 characters)
```

reviewboard/reviews/managers.py (Diff revision 3)

Show all issues

E999 IndentationError: unindent does not match any outer indentation level

Commit:

-	6418c8a0cbee8db932ef79b7c79734e0c184621f
+	a25c02bbb2ba1906cee78173ca9be03ee8e2a27a

Diff:

Revision 4 (+59)

Show changes

	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/reviews/managers.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/managers.py (Diff revision 4)

Show all issues

E128 continuation line under-indented for visual indent

reviewboard/reviews/managers.py (Diff revision 4)
Show all issues
```
W503 line break before binary operator
```

reviewboard/reviews/managers.py (Diff revision 4)

Show all issues

E128 continuation line under-indented for visual indent

reviewboard/reviews/managers.py (Diff revision 4)
Show all issues
```
W503 line break before binary operator
```

reviewboard/datagrids/builtin_items.py (Diff revision 4)

Show all issues

This isn't correct (copy/paste-o?)

mukhtar Nov. 10, 2017, 4:48 p.m.

I noticed that and fixed it, but didn't publish the newest-modified review request.

reviewboard/datagrids/builtin_items.py (Diff revision 4)

Show all issues

This should have a "Yields:" section. See https://www.notion.so/reviewboard/Writing-Codebase-Documentation-e16312b5f061437cb73cbfa369ac3cb5

reviewboard/datagrids/builtin_items.py (Diff revision 4)
Show all issues
```
The view ID should use a hyphen rather than an underscore.
```

reviewboard/datagrids/grids.py (Diff revision 4)

Show all issues

I suspect we want this to be the first item in the sidebar.

reviewboard/datagrids/grids.py (Diff revision 4)

Show all issues

This should probably be changed to "My open outgoing review requests"

reviewboard/datagrids/grids.py (Diff revision 4)

Show all issues

This should probably be changed to "All my open outgoing review requests"

reviewboard/datagrids/grids.py (Diff revision 4)

Show all issues

We should change this to use sentence casing rather than title casing.

reviewboard/datagrids/grids.py (Diff revision 4)

Show all issues

Can we put this as the first thing checked? The view string should also have a hyphen instead of an underscore.

reviewboard/datagrids/grids.py (Diff revision 4)

Show all issues

This should probably be "My open incoming and outgoin review requests"

reviewboard/datagrids/grids.py (Diff revision 4)
Show all issues
```
Should change this to be sentence casing.
```
reviewboard/datagrids/grids.py (Diff revision 4)
Show all issues
```
Should change this to be sentence casing.
```
reviewboard/datagrids/grids.py (Diff revision 4)
Show all issues
```
Should change this to be sentence casing.
```
reviewboard/datagrids/grids.py (Diff revision 4)
Show all issues
```
Should change this to be sentence casing.
```

reviewboard/reviews/managers.py (Diff revision 4)

Show all issues

This should probably be named get_my_reviews_query to match other, similar method names.

reviewboard/reviews/managers.py (Diff revision 4)

Show all issues

The docstring here needs "Args:" and "Returns:" sections. See https://www.notion.so/reviewboard/Writing-Codebase-Documentation-e16312b5f061437cb73cbfa369ac3cb5 for some info on these.

reviewboard/reviews/managers.py (Diff revision 4)

Show all issues

This needs a docstring (I know others don't have them but they're old code).

Commit:

-	a25c02bbb2ba1906cee78173ca9be03ee8e2a27a
+	f7fdbd0b40a71f767de6ac76fd65d23c3bf55fc9

Diff:

Revision 5 (+66 -8)

Show changes

	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/reviews/managers.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commit:

-	f7fdbd0b40a71f767de6ac76fd65d23c3bf55fc9
+	b036a3f48566bd37f74f2f88e4a7378f0cfaed2c

Diff:

Revision 6 (+86 -9)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/accounts/evolutions/__init__.py
	reviewboard/accounts/evolutions/total_my_review_request_count.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/reviews/managers.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/accounts/evolutions/total_my_review_request_count.py (Diff revision 6)
Show all issues
```
W292 no newline at end of file
```

reviewboard/accounts/admin.py (Diff revision 6)

Show all issues

Can we call the column "my_reviews_count" to match the name used elsewhere? "my review request count" sounds almost like it's the outgoing review requests.

reviewboard/datagrids/builtin_items.py (Diff revision 6)
Show all issues
```
This needs a "Yields" section.
```
reviewboard/datagrids/grids.py (Diff revision 6)
Show all issues
```
typo: outgoin
```

reviewboard/datagrids/grids.py (Diff revision 6)

Show all issues

This shouldn't include the word "open", since it's all including both open and closed.

reviewboard/reviews/managers.py (Diff revision 6)

Show all issues

This should be in the imperative mood ("Return" instead of "Returns").

This docstring also needs Args/Returns sections.

mukhtar Nov. 21, 2017, 6:27 p.m.

Should I also change the others to be in the imperative mood (I mean the old code)?

david Nov. 25, 2017, 11:41 a.m.

If you want to do that in a separate change that's fine but I wouldn't include it in this.

reviewboard/reviews/managers.py (Diff revision 6)
Show all issues
```
This needs a docstring.
```

Summary:

-	[WIP] Adding my reviews section to my dashboard sidebar.
+	Adding my reviews section to my dashboard sidebar.

Description:

~		[Will fix it later] Adding my reviews section to the dashboard sidebar.
	~	When user login to Review Board dashboard, they would like
	+	to see all their open requests from incoming and outgoing.
	+	Therefore, adding a new section that is called 'My Reviews'
	+	will allow users to see all their open requests.

Testing Done:

	+	Added a unit test, which passes (along with all other tests).
	+
	+	Created test review requests that will be open under incoming and outgoing sections.
	+	Ran it using this command ./tests/runtests.py reviewboard.reviews.tests.test_review_request_manager
	+	The test calls the query that merge the requests.
	+	It will check if the requests are merged successfully than it passes the test.

Commit:

-	b036a3f48566bd37f74f2f88e4a7378f0cfaed2c
+	18417949472713829dd083f3a3a09c1d7c5a70c1

Diff:

Revision 7 (+129 -10)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/accounts/evolutions/__init__.py
	reviewboard/accounts/evolutions/total_my_reviews_count.py
	reviewboard/accounts/fixtures/test_users.json
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/reviews/managers.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	Adding my reviews section to my dashboard sidebar.
+	Adding my reviews section to the dashboard's sidebar.

Commit:

-	18417949472713829dd083f3a3a09c1d7c5a70c1
+	e4408708271a06f57b6d077b6465bf5eacb2d637

Diff:

Revision 8 (+149 -10)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/accounts/evolutions/__init__.py
	reviewboard/accounts/evolutions/total_my_reviews_count.py
	reviewboard/accounts/fixtures/test_users.json
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/reviews/managers.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commit:

-	e4408708271a06f57b6d077b6465bf5eacb2d637
+	cfa9c180208fc4bead2e3ba9984cf4dcdb84c439

Diff:

Revision 9 (+150 -10)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/accounts/evolutions/__init__.py
	reviewboard/accounts/evolutions/total_my_reviews_count.py
	reviewboard/accounts/fixtures/test_users.json
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/reviews/managers.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/accounts/evolutions/total_my_reviews_count.py (Diff revision 9)

Show all issues

New file should include module docstring.

mukhtar Dec. 10, 2017, 4:55 p.m.

This is only to add evolution to the DB. I don't think it needs docstring.

reviewboard/reviews/managers.py (Diff revision 9)

Show all issues

Maybe add a description of what get_my_reviews_query does, and add as an additional note that it's meant to be passed to ReviewRequest.objects.public()

Commit:

-	cfa9c180208fc4bead2e3ba9984cf4dcdb84c439
+	ceed173e2f4e5cac58bc01789c91fbfdf720f5f9

Diff:

Revision 10 (+152 -10)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/accounts/evolutions/__init__.py
	reviewboard/accounts/evolutions/total_my_reviews_count.py
	reviewboard/accounts/fixtures/test_users.json
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/reviews/managers.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Adding my reviews section to the dashboard's sidebar.

flake8

Description:

Description:

Branch:

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commit:

Diff:

Checks run (2 succeeded)

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Summary:

Description:

Testing Done:

Commit:

Diff:

Checks run (2 succeeded)

Summary:

Commit:

Diff:

Checks run (2 succeeded)

Commit:

Diff:

Checks run (2 succeeded)

Commit:

Diff:

Checks run (2 succeeded)

Status: Discarded