Summary

[WIP] Adding MessageBus

Review Request #9235 — Created Sept. 29, 2017 and discarded Jan. 29, 2019, 1:46 p.m.

Information

Owner

nicho

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

On the client side message requests can be registered at a desired time
interval. The minimum desired time interval is the interval in which
message requests are made to MessageBus, at url /messagebus/. There is
currently no handling of the payload response. A MessageRequest called
ReviewRequestUpdatesMessageRequest was created to handle storing
relevant data (namely the review request id), which is sent alongside the
associated message_provider_id as parameters of the request to the
message bus.

On the server side, requests, identified by their message_provider_id,
pass their data to the appropriate MessageProvider, which is responsible
for accumulating messages and writing the data to the payload. Currently,
a message provider has been created for review request updates, ultimately
to replace the existing functionality of the ReviewRequestUpdatesView.
This MessageProvider returns the exact same data as you would expect by
going to the url /r/<#>/_updates.

Testing Done

A ReviewRequestUpdatesMessageRequest was created and registered to the
client side message bus. The request is received by the server side
message bus, and the request arguments are passed to the
ReviewRequestUpdatesMessageProvider. Any entries registered to the
message request have their payloads properly returned. Not providing an
entry will request all the entries. The data returned, which consists of
two payloads which match up exactly with what url /r/<#>/_updates would
output (message bus is going to replace this, so consistency between the
two is important).

Issues

Description	From	Last Updated
F401 'django.conf.urls.patterns' imported but unused	reviewbot	Oct. 28, 2017, 5:19 p.m.
F401 'reviewboard.messagebus.views' imported but unused	reviewbot	Oct. 28, 2017, 5:19 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Oct. 28, 2017, 5:19 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Oct. 28, 2017, 5:19 p.m.
Col: 10 Expected an assignment or function call and instead saw an expression.	reviewbot	Oct. 28, 2017, 5:19 p.m.
Col: 35 Expected '===' and instead saw '=='.	reviewbot	Oct. 28, 2017, 5:19 p.m.
Col: 6 Missing semicolon.	reviewbot	Oct. 28, 2017, 5:19 p.m.
F401 'django.conf.urls.patterns' imported but unused	reviewbot	Nov. 5, 2017, 7:31 a.m.
F401 'reviewboard.messagebus.views' imported but unused	reviewbot	Nov. 18, 2017, 7:30 p.m.
F401 'django.template.loader' imported but unused	reviewbot	Oct. 29, 2017, 8:45 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Oct. 29, 2017, 8:45 a.m.
E703 statement ends with a semicolon	reviewbot	Oct. 29, 2017, 8:45 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Oct. 29, 2017, 8:46 a.m.
E231 missing whitespace after ':'	reviewbot	Oct. 29, 2017, 8:46 a.m.
Col: 29 Missing '()' invoking a constructor.	reviewbot	Oct. 29, 2017, 8:47 a.m.
Col: 14 Missing 'new' prefix when invoking a constructor.	reviewbot	Oct. 29, 2017, 8:47 a.m.
This file is missing a file-level docstring.	brennie	Nov. 18, 2017, 7:30 p.m.
F401 'djblets.registries.registry.ALREADY_REGISTERED' imported but unused	reviewbot	Nov. 5, 2017, 2:29 p.m.
F401 'reviewboard.messagebus.provider.MessageProvider' imported but unused	reviewbot	Nov. 5, 2017, 2:30 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 5, 2017, 2:30 p.m.
E265 block comment should start with '# '	reviewbot	Nov. 5, 2017, 2:31 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 5, 2017, 2:31 p.m.
Missing a class-level docstring. This class should inheirit from object.	brennie	Nov. 5, 2017, 2:39 p.m.
unicode.	brennie	Nov. 5, 2017, 2:40 p.m.
Remove this blank line.	brennie	Nov. 5, 2017, 2:41 p.m.
Blank line between these.	brennie	Nov. 5, 2017, 2:41 p.m.
We should use six.iteritems(obj) because in Python 2, dict.items returns a list instead of a generator. You can get six …	brennie	Nov. 5, 2017, 2:45 p.m.
Blank line between these.	brennie	Nov. 5, 2017, 2:45 p.m.
Missing a docstring.	brennie	Nov. 18, 2017, 7:29 p.m.
F821 undefined name 'payload'	reviewbot	Nov. 5, 2017, 2:32 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Nov. 5, 2017, 2:33 p.m.
F401 'datetime' imported but unused	reviewbot	Nov. 5, 2017, 2:33 p.m.
E231 missing whitespace after ':'	reviewbot	Nov. 5, 2017, 2:33 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Nov. 5, 2017, 2:34 p.m.
F841 local variable 'x' is assigned to but never used	reviewbot	Nov. 5, 2017, 2:35 p.m.
E303 too many blank lines (3)	reviewbot	Nov. 5, 2017, 2:36 p.m.
F841 local variable 'x' is assigned to but never used	reviewbot	Nov. 5, 2017, 2:36 p.m.
F401 'reviewboard.messagebus.views' imported but unused	reviewbot	Nov. 5, 2017, 2:37 p.m.
This list should be kept in alphabetical order.	brennie	Nov. 5, 2017, 2:47 p.m.
Blank line between ) and {. Same for all cases below.	brennie	Nov. 5, 2017, 2:48 p.m.
Col: 49 Expected '===' and instead saw '=='.	reviewbot	Nov. 5, 2017, 2:38 p.m.
Col: 22 Missing semicolon.	reviewbot	Nov. 5, 2017, 2:38 p.m.
Space after //. Missing period.	brennie	Nov. 5, 2017, 2:48 p.m.
You can use an arrow function here, e.g. setTimeout(() => model._loadUpdates(), this._intervalMS);	brennie	Nov. 5, 2017, 2:49 p.m.
Col: 10 'MBRequest' is defined but never used.	reviewbot	Nov. 5, 2017, 2:38 p.m.
This should be a member of the RB namespace e.g. RB.MessageBusRequest = function MessageBusRequest() {}; Also, this might be a …	brennie	Nov. 5, 2017, 2:51 p.m.
Col: 19 Missing semicolon.	reviewbot	Nov. 5, 2017, 2:38 p.m.
Col: 25 Missing semicolon.	reviewbot	Nov. 5, 2017, 2:38 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 26, 2017, 12:55 p.m.
E265 block comment should start with '# '	reviewbot	Nov. 26, 2017, 12:55 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 26, 2017, 12:55 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 26, 2017, 12:55 p.m.
F401 'django.contrib.auth.decorators.login_required' imported but unused	reviewbot	Nov. 26, 2017, 12:55 p.m.
F401 'django.utils.decorators.method_decorator' imported but unused	reviewbot	Nov. 26, 2017, 12:56 p.m.
F401 'django.utils.six.moves.cStringIO as StringIO' imported but unused	reviewbot	Nov. 26, 2017, 12:56 p.m.
F401 'reviewboard.reviews.views.ReviewRequestViewMixin' imported but unused	reviewbot	Nov. 26, 2017, 12:56 p.m.
F401 'reviewboard.site.decorators.check_local_site_access' imported but unused	reviewbot	Nov. 26, 2017, 12:56 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Nov. 26, 2017, 12:57 p.m.
F821 undefined name 'dateutil'	reviewbot	Nov. 26, 2017, 12:57 p.m.
F821 undefined name 'is_aware'	reviewbot	Nov. 26, 2017, 12:58 p.m.
F821 undefined name 'make_aware'	reviewbot	Nov. 26, 2017, 12:58 p.m.
F821 undefined name 'utc'	reviewbot	Nov. 26, 2017, 12:58 p.m.
F821 undefined name 'HttpResponseBadRequest'	reviewbot	Nov. 26, 2017, 12:59 p.m.
F821 undefined name 'Http404'	reviewbot	Nov. 26, 2017, 12:59 p.m.
F821 undefined name 'SiteConfiguration'	reviewbot	Nov. 26, 2017, 1 p.m.
F821 undefined name 'get_last_line_number_in_diff'	reviewbot	Nov. 26, 2017, 1:01 p.m.
F821 undefined name 'get_file_chunks_in_range'	reviewbot	Nov. 26, 2017, 1:01 p.m.
F821 undefined name 'get_last_header_before_line'	reviewbot	Nov. 26, 2017, 1:01 p.m.
F821 undefined name 'Site'	reviewbot	Nov. 26, 2017, 1:02 p.m.
F821 undefined name 'exception_traceback_string'	reviewbot	Nov. 26, 2017, 1:02 p.m.
F821 undefined name 'Site'	reviewbot	Nov. 26, 2017, 1:02 p.m.
Col: 25 ['review_id'] is better written in dot notation.	reviewbot	Nov. 26, 2017, 1:03 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Dec. 8, 2017, 2:38 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Dec. 8, 2017, 2:38 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Dec. 8, 2017, 2:38 p.m.
MBRequest doesn't seem to be a thing (here and elsewhere). Do you mean RB.MessageRequest?	brennie	Dec. 8, 2017, 12:30 p.m.
Col: 39 Missing semicolon.	reviewbot	Dec. 8, 2017, 2:38 p.m.
F401 'django.utils.six' imported but unused	reviewbot	Dec. 8, 2017, 2:51 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Dec. 8, 2017, 2:51 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Dec. 8, 2017, 2:53 p.m.
E265 block comment should start with '# '	reviewbot	Dec. 8, 2017, 2:53 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Dec. 8, 2017, 2:53 p.m.
E501 line too long (88 > 79 characters)	reviewbot	Dec. 8, 2017, 2:54 p.m.
E303 too many blank lines (2)	reviewbot	Dec. 8, 2017, 2:54 p.m.
F401 'django.http.Http404' imported but unused	reviewbot	Dec. 8, 2017, 2:55 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Dec. 8, 2017, 2:55 p.m.
E265 block comment should start with '# '	reviewbot	Dec. 8, 2017, 2:55 p.m.
Col: 28 Missing semicolon.	reviewbot	Dec. 8, 2017, 2:57 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Dec. 8, 2017, 3:04 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Dec. 8, 2017, 3:04 p.m.

flake8 passed.

JSHint passed.

Commit:

-	169587bd2e81bf1550a1ea4a872e280a76801e44
+	8dff877cd03fc6abed6ffb7754764f3fc3084ad7

Diff:

Revision 2 (+156)

Show changes

	reviewboard/settings.py
	reviewboard/urls.py
	reviewboard/messagebus/__init__.py
	reviewboard/messagebus/urls.py
	reviewboard/messagebus/views.py
	reviewboard/static/rb/js/messagebus/test.js
	reviewboard/templates/messagebus/test.html

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

reviewboard/messagebus/urls.py (Diff revision 2)
The issue has been dropped. Show all issues
```
F401 'django.conf.urls.patterns' imported but unused
```
reviewboard/messagebus/urls.py (Diff revision 2)
The issue has been dropped. Show all issues
```
F401 'reviewboard.messagebus.views' imported but unused
```
reviewboard/messagebus/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/messagebus/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```

JSHint

reviewboard/static/rb/js/messagebus/test.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 10
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/rb/js/messagebus/test.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 35
 Expected '===' and instead saw '=='.
```
reviewboard/static/rb/js/messagebus/test.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 6
 Missing semicolon.
```

Change Summary:

Changed how MessageBus works, and added more functionality.

Summary:

-	[WIP] Adding MessageBus as an app.
+	[WIP] Adding MessageBus

Description:

~		Created the endpoint for MessageBus. Currently, it only shows "Page Test" as the page message (I had to learn how Django URLs worked). The idea will be to use this address to send the aggregated request data (and on the python side, process it). Currently none of that is implemented.
	~	On the client side message requests can be registered at a desired time
	+	interval. The minimum desired time interval is the interval in which
	+	message requests are made to MessageBus, at url /messagebus/. Currently,
	+	registering requests does not have an effect on the data being returned
	+	from the server (a test request is made instead).
	+
	+	On the server side, MessageProviders can be registered through MessageBus
	+	to a registry. MessageBus requests will seperate individual message
	+	requests, and pass the corresponding request to their appropriate
	+	MessageProvider, if it exists (currently, there is no error handling if the
	+	MessageProvider doesn't exist). The MessageProvider handles getting any
	+	data, and returns it to MessageBus to be aggregrated and sent back to the
	+	client.

Testing Done:

~		Going to the address /messagebus/ loads without error, and properly displays "Page Test".
	~	Created a test MessageProvider and registered it to MessageBus. There is
	+	some work done on registering message requests, but it isn't currently in
	+	use. A test request is made to the MessageBus, and the request is passed to
	+	the test MessageProvider. Different MessageProviders (and message requests)
	+	can be made. The test request is currently only processed to return a
	+	string, but in practice could be used to query the web api.

Commit:

-	8dff877cd03fc6abed6ffb7754764f3fc3084ad7
+	1a2f0e9bf6905ace4096a5a67cfab0d383881eb3

Diff:

Revision 3 (+42)

Show changes

	reviewboard/settings.py
	reviewboard/staticbundles.py
	reviewboard/urls.py
	reviewboard/messagebus/__init__.py
	reviewboard/messagebus/urls.py
	reviewboard/messagebus/views.py
	reviewboard/static/rb/js/messagebus/test.js
	reviewboard/templates/messagebus/test.html

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

reviewboard/messagebus/urls.py (Diff revision 3)
The issue has been dropped. Show all issues
```
F401 'django.conf.urls.patterns' imported but unused
```

reviewboard/messagebus/urls.py (Diff revision 3)

The issue has been resolved. Show all issues

F401 'reviewboard.messagebus.views' imported but unused

chipx86 Nov. 10, 2017, 5:56 p.m.

This shouldn't be dropped. We should never have an unused import, and new url() entries should actually reference the functions/classes directly on the module instead of providing the dotted name form (for future Django compatibility).

reviewboard/messagebus/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
F401 'django.template.loader' imported but unused
```
reviewboard/messagebus/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/messagebus/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E703 statement ends with a semicolon
```
reviewboard/messagebus/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/messagebus/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```

JSHint

reviewboard/static/rb/js/messagebus/test.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 29
 Missing '()' invoking a constructor.
```
reviewboard/static/rb/js/messagebus/test.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 14
 Missing 'new' prefix when invoking a constructor.
```

Change Summary:

Added the ability to register callbacks for message requests, and changed the payload format.

Commit:

-	1a2f0e9bf6905ace4096a5a67cfab0d383881eb3
+	02638021ed683c87bd3170cb8f872060f3dfad91

Diff:

Revision 4 (+324)

Show changes

	reviewboard/settings.py
	reviewboard/staticbundles.py
	reviewboard/urls.py
	reviewboard/messagebus/__init__.py
	reviewboard/messagebus/base.py
	reviewboard/messagebus/provider.py
	reviewboard/messagebus/urls.py
	reviewboard/messagebus/views.py
	4 more

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

reviewboard/messagebus/base.py (Diff revision 4)
The issue has been resolved. Show all issues
```
F401 'djblets.registries.registry.ALREADY_REGISTERED' imported but unused
```
reviewboard/messagebus/base.py (Diff revision 4)
The issue has been resolved. Show all issues
```
F401 'reviewboard.messagebus.provider.MessageProvider' imported but unused
```
reviewboard/messagebus/base.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/messagebus/base.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/messagebus/base.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/messagebus/base.py (Diff revision 4)
The issue has been dropped. Show all issues
```
F821 undefined name 'payload'
```
reviewboard/messagebus/base.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/messagebus/provider.py (Diff revision 4)
The issue has been resolved. Show all issues
```
F401 'datetime' imported but unused
```
reviewboard/messagebus/provider.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```
reviewboard/messagebus/provider.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/messagebus/provider.py (Diff revision 4)
The issue has been dropped. Show all issues
```
F841 local variable 'x' is assigned to but never used
```
reviewboard/messagebus/provider.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E303 too many blank lines (3)
```
reviewboard/messagebus/provider.py (Diff revision 4)
The issue has been dropped. Show all issues
```
F841 local variable 'x' is assigned to but never used
```
reviewboard/messagebus/urls.py (Diff revision 4)
The issue has been resolved. Show all issues
```
F401 'reviewboard.messagebus.views' imported but unused
```

JSHint

reviewboard/static/rb/js/messagebus/messageBus.js (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 49
 Expected '===' and instead saw '=='.
```
reviewboard/static/rb/js/messagebus/messageBus.js (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 22
 Missing semicolon.
```
reviewboard/static/rb/js/messagebus/messageBus.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 10
 'MBRequest' is defined but never used.
```
reviewboard/static/rb/js/messagebus/messageBus.js (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 19
 Missing semicolon.
```
reviewboard/static/rb/js/messagebus/messageBus.js (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 25
 Missing semicolon.
```

reviewboard/messagebus/base.py (Diff revision 4)
The issue has been resolved. Show all issues
```
This file is missing a file-level docstring.
```
reviewboard/messagebus/base.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Missing a class-level docstring.
This class should inheirit from object.
```
reviewboard/messagebus/base.py (Diff revision 4)
The issue has been resolved. Show all issues
```
unicode.
```
reviewboard/messagebus/base.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Remove this blank line.
```
reviewboard/messagebus/base.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Blank line between these.
```

reviewboard/messagebus/base.py (Diff revision 4)

The issue has been resolved. Show all issues

We should use six.iteritems(obj) because in Python 2, dict.items returns a list instead of a generator.
You can get six from:

from django.utils import six

reviewboard/messagebus/base.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/messagebus/base.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Missing a docstring.
```
1. NI
  
  nicho Nov. 18, 2017, 7:30 p.m.
  Dropped as function no longer exists in current version.
reviewboard/settings.py (Diff revision 4)
The issue has been resolved. Show all issues
```
This list should be kept in alphabetical order.
```
reviewboard/static/rb/js/messagebus/messageBus.js (Diff revision 4)
The issue has been resolved. Show all issues
```
Blank line between ) and {. Same for all cases below.
```
reviewboard/static/rb/js/messagebus/messageBus.js (Diff revision 4)
The issue has been resolved. Show all issues
```
Space after //. Missing period.
```

reviewboard/static/rb/js/messagebus/messageBus.js (Diff revision 4)

The issue has been resolved. Show all issues

You can use an arrow function here, e.g.

setTimeout(() => model._loadUpdates(), this._intervalMS);

reviewboard/static/rb/js/messagebus/messageBus.js (Diff revision 4)

The issue has been resolved. Show all issues

This should be a member of the RB namespace e.g.

RB.MessageBusRequest = function MessageBusRequest() {};


Also, this might be a good place to use a Backbone model?

nicho Nov. 5, 2017, 2:52 p.m.

Currently just using this for testing purposes, going to work in a proper Backbone model for MessageRequests soon.

Change Summary:

Created a message provider to handle review request updates.

Description:

		On the client side message requests can be registered at a desired time
		interval. The minimum desired time interval is the interval in which
~		message requests are made to MessageBus, at url /messagebus/. Currently,
~		registering requests does not have an effect on the data being returned
~		from the server (a test request is made instead).
	~	message requests are made to MessageBus, at url /messagebus/. There is
	~	currently no handling of the payload response. A `MessageRequest` called
	~	`ReviewRequestUpdatesMessageRequest` was created to handle storing
	+	relevant data (namely the review request id), which is sent alongside the
	+	associated `message_provider_id` as parameters of the request to the
	+	message bus.

~		On the server side, MessageProviders can be registered through MessageBus
~		to a registry. MessageBus requests will seperate individual message
~		requests, and pass the corresponding request to their appropriate
~		MessageProvider, if it exists (currently, there is no error handling if the
~		MessageProvider doesn't exist). The MessageProvider handles getting any
~		data, and returns it to MessageBus to be aggregrated and sent back to the
~		client.
	~	On the server side, requests, identified by their `message_provider_id`,
	~	pass their data to the appropriate `MessageProvider`, which is responsible
	~	for accumulating messages and writing the data to the payload. Currently,
	~	a message provider has been created for review request updates, ultimately
	~	to replace the existing functionality of the ReviewRequestUpdatesView.
	~	This MessageProvider returns the exact same data as you would expect by
	~	going to the url /r/<#>/_updates.

Testing Done:

~		Created a test MessageProvider and registered it to MessageBus. There is
~		some work done on registering message requests, but it isn't currently in
~		use. A test request is made to the MessageBus, and the request is passed to
~		the test MessageProvider. Different MessageProviders (and message requests)
~		can be made. The test request is currently only processed to return a
~		string, but in practice could be used to query the web api.
	~	A `ReviewRequestUpdatesMessageRequest` was created and registered to the
	~	client side message bus. The request is received by the server side
	~	message bus, and the request arguments are passed to the
	~	`ReviewRequestUpdatesMessageProvider`. No entries are provided in the
	~	request arguments. The server responds with the review request update
	~	data, which consists of two payloads which match up exactly with what
	+	url /r/<#>/_updates would output (message bus is going to replace this,
	+	so consistency between the two is important).

Commit:

-	02638021ed683c87bd3170cb8f872060f3dfad91
+	47a53a8ed141df763e02daf3ca6a04f0f55d548f

Diff:

Revision 5 (+630)

Show changes

	reviewboard/settings.py
	reviewboard/staticbundles.py
	reviewboard/urls.py
	reviewboard/messagebus/__init__.py
	reviewboard/messagebus/base.py
	reviewboard/messagebus/provider.py
	reviewboard/messagebus/review.py
	reviewboard/messagebus/urls.py
	5 more

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

reviewboard/messagebus/base.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/messagebus/base.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/messagebus/base.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/messagebus/provider.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F401 'django.contrib.auth.decorators.login_required' imported but unused
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F401 'django.utils.decorators.method_decorator' imported but unused
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F401 'django.utils.six.moves.cStringIO as StringIO' imported but unused
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F401 'reviewboard.reviews.views.ReviewRequestViewMixin' imported but unused
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F401 'reviewboard.site.decorators.check_local_site_access' imported but unused
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F821 undefined name 'dateutil'
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F821 undefined name 'is_aware'
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F821 undefined name 'make_aware'
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F821 undefined name 'utc'
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F821 undefined name 'HttpResponseBadRequest'
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F821 undefined name 'Http404'
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F821 undefined name 'SiteConfiguration'
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F821 undefined name 'get_last_line_number_in_diff'
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F821 undefined name 'get_file_chunks_in_range'
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F821 undefined name 'get_last_header_before_line'
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F821 undefined name 'Site'
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F821 undefined name 'exception_traceback_string'
```
reviewboard/messagebus/review.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F821 undefined name 'Site'
```

JSHint

reviewboard/static/rb/js/messagebus/messageBus.js (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 25
 ['review_id'] is better written in dot notation.
```

Change Summary:

Moved much of the entry update logic from the ReviewRequestPage model to the ReviewRequestUpdatesMessageRequest.

Commit:

-	47a53a8ed141df763e02daf3ca6a04f0f55d548f
+	ac1dc289c6e24e17e7502a410e414b0dbe053053

Diff:

Revision 6 (+817 -167)

Show changes

	reviewboard/settings.py
	reviewboard/staticbundles.py
	reviewboard/urls.py
	reviewboard/messagebus/__init__.py
	reviewboard/messagebus/base.py
	reviewboard/messagebus/provider.py
	reviewboard/messagebus/review.py
	reviewboard/messagebus/urls.py
	7 more

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

reviewboard/messagebus/base.py (Diff revision 6)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/messagebus/review.py (Diff revision 6)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/messagebus/review.py (Diff revision 6)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```

JSHint

reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageModel.es6.js (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 39
 Missing semicolon.
```

reviewboard/static/rb/js/messagebus/messageBus.js (Diff revision 6)

The issue has been resolved. Show all issues

MBRequest doesn't seem to be a thing (here and elsewhere). Do you mean RB.MessageRequest?

nicho Dec. 8, 2017, 12:30 p.m.

Yep, use to have it named MBRequest. Updated it to be MessageRequest.

Change Summary:

Finished the MessageProvider and MessageRequest for review request updates.

Testing Done:

~		A `ReviewRequestUpdatesMessageRequest` was created and registered to the
~		client side message bus. The request is received by the server side
~		message bus, and the request arguments are passed to the
~		`ReviewRequestUpdatesMessageProvider`. No entries are provided in the
~		request arguments. The server responds with the review request update
~		data, which consists of two payloads which match up exactly with what
~		url /r/<#>/_updates would output (message bus is going to replace this,
~		so consistency between the two is important).
	~	A `ReviewRequestUpdatesMessageRequest` was created and registered to the
	~	client side message bus. The request is received by the server side
	~	message bus, and the request arguments are passed to the
	~	`ReviewRequestUpdatesMessageProvider`. Any entries registered to the
	~	message request have their payloads properly returned. Not providing an
	~	entry will request all the entries. The data returned, which consists of
	~	two payloads which match up exactly with what url `/r/<#>/_updates` would
	~	output (message bus is going to replace this, so consistency between the
	+	two is important).

Commit:

-	ac1dc289c6e24e17e7502a410e414b0dbe053053
+	0101a54b86b91a22d3f5dd640d9d1e671e866b73

Diff:

Revision 7 (+892 -337)

Show changes

	reviewboard/settings.py
	reviewboard/staticbundles.py
	reviewboard/urls.py
	reviewboard/messagebus/__init__.py
	reviewboard/messagebus/base.py
	reviewboard/messagebus/provider.py
	reviewboard/messagebus/review.py
	reviewboard/messagebus/urls.py
	8 more

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

reviewboard/messagebus/base.py (Diff revision 7)
The issue has been resolved. Show all issues
```
F401 'django.utils.six' imported but unused
```
reviewboard/messagebus/base.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/messagebus/base.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E501 line too long (81 > 79 characters)
```
reviewboard/messagebus/base.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/messagebus/base.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E501 line too long (81 > 79 characters)
```
reviewboard/messagebus/provider.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E501 line too long (88 > 79 characters)
```
reviewboard/messagebus/provider.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```
reviewboard/messagebus/review.py (Diff revision 7)
The issue has been resolved. Show all issues
```
F401 'django.http.Http404' imported but unused
```
reviewboard/messagebus/review.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/messagebus/review.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E265 block comment should start with '# '
```

JSHint

reviewboard/static/rb/js/messagebus/messageBus.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Col: 28
 Missing semicolon.
```

Change Summary:

Fixed ReviewBot complaints.

Commit:

-	0101a54b86b91a22d3f5dd640d9d1e671e866b73
+	b5d99a29a23561a952aed05019f90019672969b3

Diff:

Revision 8 (+892 -337)

Show changes

	reviewboard/settings.py
	reviewboard/staticbundles.py
	reviewboard/urls.py
	reviewboard/messagebus/__init__.py
	reviewboard/messagebus/base.py
	reviewboard/messagebus/provider.py
	reviewboard/messagebus/review.py
	reviewboard/messagebus/urls.py
	8 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/messagebus/base.py (Diff revision 8)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/messagebus/review.py (Diff revision 8)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```

Change Summary:

Finished much of the integration of review request updates with message bus.

Commit:

-	b5d99a29a23561a952aed05019f90019672969b3
+	867e90acf304f8e657620e2570d890b1be15d411

Diff:

Revision 9 (+892 -338)

Show changes

	reviewboard/settings.py
	reviewboard/staticbundles.py
	reviewboard/urls.py
	reviewboard/messagebus/__init__.py
	reviewboard/messagebus/base.py
	reviewboard/messagebus/provider.py
	reviewboard/messagebus/review.py
	reviewboard/messagebus/urls.py
	7 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

[WIP] Adding MessageBus

Information

Reviewers

Commit:

Diff:

Checks run (2 failed)

flake8

JSHint

Change Summary:

Summary:

Description:

Testing Done:

Commit:

Diff:

Checks run (2 failed)

flake8

JSHint

Change Summary:

Commit:

Diff:

Checks run (2 failed)

flake8

JSHint

Change Summary:

Description:

Testing Done:

Commit:

Diff:

Checks run (2 failed)

flake8

JSHint

Change Summary:

Commit:

Diff:

Checks run (2 failed)

flake8

JSHint

Change Summary:

Testing Done:

Commit:

Diff:

Checks run (2 failed)

flake8

JSHint

Change Summary:

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Change Summary:

Commit:

Diff:

Checks run (2 succeeded)

Status: Discarded