flake8
passed.
JSHint
passed.
[WIP] Adding MessageBus
Review Request #9235 — Created Sept. 29, 2017 and discarded
On the client side message requests can be registered at a desired time
interval. The minimum desired time interval is the interval in which
message requests are made to MessageBus, at url /messagebus/. There is
currently no handling of the payload response. AMessageRequestcalled
ReviewRequestUpdatesMessageRequestwas created to handle storing
relevant data (namely the review request id), which is sent alongside the
associatedmessage_provider_idas parameters of the request to the
message bus.On the server side, requests, identified by their
message_provider_id,
pass their data to the appropriateMessageProvider, which is responsible
for accumulating messages and writing the data to the payload. Currently,
a message provider has been created for review request updates, ultimately
to replace the existing functionality of the ReviewRequestUpdatesView.
This MessageProvider returns the exact same data as you would expect by
going to the url /r/<#>/_updates.
A
ReviewRequestUpdatesMessageRequestwas created and registered to the
client side message bus. The request is received by the server side
message bus, and the request arguments are passed to the
ReviewRequestUpdatesMessageProvider. Any entries registered to the
message request have their payloads properly returned. Not providing an
entry will request all the entries. The data returned, which consists of
two payloads which match up exactly with what url/r/<#>/_updateswould
output (message bus is going to replace this, so consistency between the
two is important).
| Description | From | Last Updated |
|---|---|---|
|
F401 'django.conf.urls.patterns' imported but unused |
 reviewbot
|
|
|
F401 'reviewboard.messagebus.views' imported but unused |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
Col: 10 Expected an assignment or function call and instead saw an expression. |
reviewbot
|
|
|
Col: 35 Expected '===' and instead saw '=='. |
reviewbot
|
|
|
Col: 6 Missing semicolon. |
reviewbot
|
|
|
F401 'django.conf.urls.patterns' imported but unused |
reviewbot
|
|
|
F401 'reviewboard.messagebus.views' imported but unused |
reviewbot
|
|
|
F401 'django.template.loader' imported but unused |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E703 statement ends with a semicolon |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E231 missing whitespace after ':' |
reviewbot
|
|
|
Col: 29 Missing '()' invoking a constructor. |
reviewbot
|
|
|
Col: 14 Missing 'new' prefix when invoking a constructor. |
reviewbot
|
|
|
This file is missing a file-level docstring. |
 brennie
|
|
|
F401 'djblets.registries.registry.ALREADY_REGISTERED' imported but unused |
reviewbot
|
|
|
F401 'reviewboard.messagebus.provider.MessageProvider' imported but unused |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E265 block comment should start with '# ' |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
Missing a class-level docstring. This class should inheirit from object. |
brennie
|
|
|
unicode. |
brennie
|
|
|
Remove this blank line. |
brennie
|
|
|
Blank line between these. |
brennie
|
|
|
We should use six.iteritems(obj) because in Python 2, dict.items returns a list instead of a generator. You can get six … |
brennie
|
|
|
Blank line between these. |
brennie
|
|
|
Missing a docstring. |
brennie
|
|
|
F821 undefined name 'payload' |
reviewbot
|
|
|
E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
F401 'datetime' imported but unused |
reviewbot
|
|
|
E231 missing whitespace after ':' |
reviewbot
|
|
|
E127 continuation line over-indented for visual indent |
reviewbot
|
|
|
F841 local variable 'x' is assigned to but never used |
reviewbot
|
|
|
E303 too many blank lines (3) |
reviewbot
|
|
|
F841 local variable 'x' is assigned to but never used |
reviewbot
|
|
|
F401 'reviewboard.messagebus.views' imported but unused |
reviewbot
|
|
|
This list should be kept in alphabetical order. |
brennie
|
|
|
Blank line between ) and {. Same for all cases below. |
brennie
|
|
|
Col: 49 Expected '===' and instead saw '=='. |
reviewbot
|
|
|
Col: 22 Missing semicolon. |
reviewbot
|
|
|
Space after //. Missing period. |
brennie
|
|
|
You can use an arrow function here, e.g. setTimeout(() => model._loadUpdates(), this._intervalMS); |
brennie
|
|
|
Col: 10 'MBRequest' is defined but never used. |
reviewbot
|
|
|
This should be a member of the RB namespace e.g. RB.MessageBusRequest = function MessageBusRequest() {}; Also, this might be a … |
brennie
|
|
|
Col: 19 Missing semicolon. |
reviewbot
|
|
|
Col: 25 Missing semicolon. |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E265 block comment should start with '# ' |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
F401 'django.contrib.auth.decorators.login_required' imported but unused |
reviewbot
|
|
|
F401 'django.utils.decorators.method_decorator' imported but unused |
reviewbot
|
|
|
F401 'django.utils.six.moves.cStringIO as StringIO' imported but unused |
reviewbot
|
|
|
F401 'reviewboard.reviews.views.ReviewRequestViewMixin' imported but unused |
reviewbot
|
|
|
F401 'reviewboard.site.decorators.check_local_site_access' imported but unused |
reviewbot
|
|
|
E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
F821 undefined name 'dateutil' |
reviewbot
|
|
|
F821 undefined name 'is_aware' |
reviewbot
|
|
|
F821 undefined name 'make_aware' |
reviewbot
|
|
|
F821 undefined name 'utc' |
reviewbot
|
|
|
F821 undefined name 'HttpResponseBadRequest' |
reviewbot
|
|
|
F821 undefined name 'Http404' |
reviewbot
|
|
|
F821 undefined name 'SiteConfiguration' |
reviewbot
|
|
|
F821 undefined name 'get_last_line_number_in_diff' |
reviewbot
|
|
|
F821 undefined name 'get_file_chunks_in_range' |
reviewbot
|
|
|
F821 undefined name 'get_last_header_before_line' |
reviewbot
|
|
|
F821 undefined name 'Site' |
reviewbot
|
|
|
F821 undefined name 'exception_traceback_string' |
reviewbot
|
|
|
F821 undefined name 'Site' |
reviewbot
|
|
|
Col: 25 ['review_id'] is better written in dot notation. |
reviewbot
|
|
|
E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
E127 continuation line over-indented for visual indent |
reviewbot
|
|
|
E127 continuation line over-indented for visual indent |
reviewbot
|
|
|
MBRequest doesn't seem to be a thing (here and elsewhere). Do you mean RB.MessageRequest? |
brennie
|
|
|
Col: 39 Missing semicolon. |
reviewbot
|
|
|
F401 'django.utils.six' imported but unused |
reviewbot
|
|
|
E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
E265 block comment should start with '# ' |
reviewbot
|
|
|
E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
E501 line too long (88 > 79 characters) |
reviewbot
|
|
|
E303 too many blank lines (2) |
reviewbot
|
|
|
F401 'django.http.Http404' imported but unused |
reviewbot
|
|
|
E127 continuation line over-indented for visual indent |
reviewbot
|
|
|
E265 block comment should start with '# ' |
reviewbot
|
|
|
Col: 28 Missing semicolon. |
reviewbot
|
|
|
E127 continuation line over-indented for visual indent |
reviewbot
|
|
|
E128 continuation line under-indented for visual indent |
reviewbot
|
NI
- Commit:
-
169587bd2e81bf1550a1ea4a872e280a76801e448dff877cd03fc6abed6ffb7754764f3fc3084ad7
Checks run (2 failed)
flake8
failed.
JSHint
failed.
flake8
JSHint
NI
- Change Summary:
-
Changed how MessageBus works, and added more functionality.
- Summary:
-
[WIP] Adding MessageBus as an app.[WIP] Adding MessageBus
- Description:
-
~ Created the endpoint for MessageBus. Currently, it only shows "Page Test" as the page message (I had to learn how Django URLs worked). The idea will be to use this address to send the aggregated request data (and on the python side, process it). Currently none of that is implemented.
~ On the client side message requests can be registered at a desired time
+ interval. The minimum desired time interval is the interval in which + message requests are made to MessageBus, at url /messagebus/. Currently, + registering requests does not have an effect on the data being returned + from the server (a test request is made instead). + + On the server side, MessageProviders can be registered through MessageBus
+ to a registry. MessageBus requests will seperate individual message + requests, and pass the corresponding request to their appropriate + MessageProvider, if it exists (currently, there is no error handling if the + MessageProvider doesn't exist). The MessageProvider handles getting any + data, and returns it to MessageBus to be aggregrated and sent back to the + client. - Testing Done:
-
~ Going to the address /messagebus/ loads without error, and properly displays "Page Test".
~ Created a test MessageProvider and registered it to MessageBus. There is
+ some work done on registering message requests, but it isn't currently in + use. A test request is made to the MessageBus, and the request is passed to + the test MessageProvider. Different MessageProviders (and message requests) + can be made. The test request is currently only processed to return a + string, but in practice could be used to query the web api. - Commit:
-
8dff877cd03fc6abed6ffb7754764f3fc3084ad71a2f0e9bf6905ace4096a5a67cfab0d383881eb3
Checks run (2 failed)
flake8
failed.
JSHint
failed.
flake8
JSHint
NI
- Change Summary:
-
Added the ability to register callbacks for message requests, and changed the payload format.
- Commit:
-
1a2f0e9bf6905ace4096a5a67cfab0d383881eb302638021ed683c87bd3170cb8f872060f3dfad91
Checks run (2 failed)
flake8
failed.
JSHint
failed.
flake8
JSHint
-
-
-
-
-
-
-
We should use
six.iteritems(obj)because in Python 2,dict.itemsreturns a list instead of a generator.You can get
sixfrom:from django.utils import six -
-
-
-
-
-
-
This should be a member of the
RBnamespace e.g.RB.MessageBusRequest = function MessageBusRequest() {};Also, this might be a good place to use a Backbone model?
NI
- Change Summary:
-
Created a message provider to handle review request updates.
- Description:
-
On the client side message requests can be registered at a desired time
interval. The minimum desired time interval is the interval in which ~ message requests are made to MessageBus, at url /messagebus/. Currently, ~ registering requests does not have an effect on the data being returned ~ from the server (a test request is made instead). ~ message requests are made to MessageBus, at url /messagebus/. There is ~ currently no handling of the payload response. A MessageRequestcalled~ ReviewRequestUpdatesMessageRequestwas created to handle storing+ relevant data (namely the review request id), which is sent alongside the + associated message_provider_idas parameters of the request to the+ message bus. ~ On the server side, MessageProviders can be registered through MessageBus
~ to a registry. MessageBus requests will seperate individual message ~ requests, and pass the corresponding request to their appropriate ~ MessageProvider, if it exists (currently, there is no error handling if the ~ MessageProvider doesn't exist). The MessageProvider handles getting any ~ data, and returns it to MessageBus to be aggregrated and sent back to the ~ client. ~ On the server side, requests, identified by their
message_provider_id,~ pass their data to the appropriate MessageProvider, which is responsible~ for accumulating messages and writing the data to the payload. Currently, ~ a message provider has been created for review request updates, ultimately ~ to replace the existing functionality of the ReviewRequestUpdatesView. ~ This MessageProvider returns the exact same data as you would expect by ~ going to the url /r/<#>/_updates. - Testing Done:
-
~ Created a test MessageProvider and registered it to MessageBus. There is
~ some work done on registering message requests, but it isn't currently in ~ use. A test request is made to the MessageBus, and the request is passed to ~ the test MessageProvider. Different MessageProviders (and message requests) ~ can be made. The test request is currently only processed to return a ~ string, but in practice could be used to query the web api. ~ A
ReviewRequestUpdatesMessageRequestwas created and registered to the~ client side message bus. The request is received by the server side ~ message bus, and the request arguments are passed to the ~ ReviewRequestUpdatesMessageProvider. No entries are provided in the~ request arguments. The server responds with the review request update ~ data, which consists of two payloads which match up exactly with what + url /r/<#>/_updates would output (message bus is going to replace this, + so consistency between the two is important). - Commit:
-
02638021ed683c87bd3170cb8f872060f3dfad9147a53a8ed141df763e02daf3ca6a04f0f55d548f
Checks run (2 failed)
flake8
failed.
JSHint
failed.
flake8
JSHint
NI
- Change Summary:
-
Moved much of the entry update logic from the ReviewRequestPage model to the ReviewRequestUpdatesMessageRequest.
- Commit:
-
47a53a8ed141df763e02daf3ca6a04f0f55d548fac1dc289c6e24e17e7502a410e414b0dbe053053
NI
- Change Summary:
-
Finished the MessageProvider and MessageRequest for review request updates.
- Testing Done:
-
~ A
ReviewRequestUpdatesMessageRequestwas created and registered to the~ client side message bus. The request is received by the server side ~ message bus, and the request arguments are passed to the ~ ReviewRequestUpdatesMessageProvider. No entries are provided in the~ request arguments. The server responds with the review request update ~ data, which consists of two payloads which match up exactly with what ~ url /r/<#>/_updates would output (message bus is going to replace this, ~ so consistency between the two is important). ~ A
ReviewRequestUpdatesMessageRequestwas created and registered to the~ client side message bus. The request is received by the server side ~ message bus, and the request arguments are passed to the ~ ReviewRequestUpdatesMessageProvider. Any entries registered to the~ message request have their payloads properly returned. Not providing an ~ entry will request all the entries. The data returned, which consists of ~ two payloads which match up exactly with what url /r/<#>/_updateswould~ output (message bus is going to replace this, so consistency between the + two is important). - Commit:
-
ac1dc289c6e24e17e7502a410e414b0dbe0530530101a54b86b91a22d3f5dd640d9d1e671e866b73
Checks run (2 failed)
flake8
failed.
JSHint
failed.
flake8
JSHint
NI
- Change Summary:
-
Fixed ReviewBot complaints.
- Commit:
-
0101a54b86b91a22d3f5dd640d9d1e671e866b73b5d99a29a23561a952aed05019f90019672969b3
