[WIP] Add "Publish and Archive" to the review dialog.

Review Request #9220 - Created Sept. 24, 2017 and updated

Giulia Mattia
Review Board
release-3.0.x
291bd64...
reviewboard, students

This change adds a shortcut allowing people who are publishing a review
to publish the review and archive the review request all in one shot.

Manually tested adding a comment and clicking "Publish and Archive" from
the banner. Once published, the review request is marked as archived.
Manually tested adding a comment, clicking "Edit Review" from the
banner, and clicking "Publish and Archive" from the review dialog view.
Once published, the review request is marked as archived.

Added 3 unit tests, which all pass (along with all other tests). One
scenario creates a new visit and archives the review request. The other
two scenarios update existing visits from visible to visible, and
visible to archived.

Added a javascript test to ensure that onPublishClicked is called with
the correct values.

  • 2
  • 0
  • 73
  • 0
  • 75
Description From Last Updated
I think you can remove "WIP" from your summary now. David Trowbridge David Trowbridge
Can you put the last item on the next line to keep in wrapping in 80 columns? David Trowbridge David Trowbridge
Barret Rennie
Giulia Mattia
Giulia Mattia
Giulia Mattia
David Trowbridge
Giulia Mattia
David Trowbridge
Giulia Mattia
Giulia Mattia
Giulia Mattia
Giulia Mattia
David Trowbridge
Barret Rennie
Giulia Mattia
Review request changed
David Trowbridge
  1. Looking great!

  2. I think you can remove "WIP" from your summary now.

  3. Can you put the last item on the next line to keep in wrapping in 80 columns?

  4. 
      
Loading...