Summary

Added unit tests for djblets.auth.views.register. These unit tests cover registering a new user and attempting to register a user with an existing account/username.

Review Request #9219 — Created Sept. 24, 2017 and discarded Feb. 10, 2019, 9:16 a.m.

Information

Owner

slamo

Repository

Djblets

Branch

release-0.10.x

Bugs

4588

Depends On

Reviewers

Groups

djblets, students

People

Description

Added unit tests for djblets.auth.views.register. These unit tests cover registering a new user and attempting to register a user with an existing account/username.

Testing Done

Stepped through djblets.auth.views.register using ipdb to make sure that each test was hitting the proper registration flows.

Issues

Description	From	Last Updated
Pro tip: You can set a column width of 79 in pycharm settings. It is under Editor -> Code Style …	brennie	Oct. 2, 2017, 3:40 p.m.
Please limit your summary to 50-ish chars. Wrap summary & description at 72 chars.	brennie	Oct. 3, 2017, 1:31 p.m.
Needs a file-level docstring that describes what the file is or does. In this case "Unit tests for djblets.auth.views." would …	brennie	Oct. 2, 2017, 3:21 p.m.
These can be grouped together since they are both 3rd party imports.	brennie	Oct. 2, 2017, 3:24 p.m.
Needs a docstring.	brennie	Oct. 2, 2017, 3:40 p.m.
Needs a docstring.	brennie	Oct. 2, 2017, 3:27 p.m.
E501 line too long (86 > 79 characters)	reviewbot	Oct. 2, 2017, 3:35 p.m.
E501 line too long (101 > 79 characters)	reviewbot	Oct. 2, 2017, 3:35 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Oct. 2, 2017, 3:35 p.m.
Formatting to flake8's complaints can be hard, so try: self.csrf_client.get( reverse('register'), { 'username': 'testUser', 'password1': 'password', 'password2': 'password', 'email': 'user@gmail.com', …	brennie	Oct. 2, 2017, 3:41 p.m.
E501 line too long (91 > 79 characters)	reviewbot	Oct. 2, 2017, 3:36 p.m.
E501 line too long (91 > 79 characters)	reviewbot	Oct. 2, 2017, 3:36 p.m.
E501 line too long (93 > 79 characters)	reviewbot	Oct. 2, 2017, 3:36 p.m.
E501 line too long (88 > 79 characters)	reviewbot	Oct. 2, 2017, 3:36 p.m.
E501 line too long (88 > 79 characters)	reviewbot	Oct. 2, 2017, 3:36 p.m.
E501 line too long (90 > 79 characters)	reviewbot	Oct. 2, 2017, 3:36 p.m.
E501 line too long (91 > 79 characters)	reviewbot	Oct. 2, 2017, 3:36 p.m.
E501 line too long (91 > 79 characters)	reviewbot	Oct. 2, 2017, 3:36 p.m.
E501 line too long (93 > 79 characters)	reviewbot	Oct. 2, 2017, 3:36 p.m.
E501 line too long (88 > 79 characters)	reviewbot	Oct. 2, 2017, 3:36 p.m.
E501 line too long (88 > 79 characters)	reviewbot	Oct. 2, 2017, 3:36 p.m.
E501 line too long (95 > 79 characters)	reviewbot	Oct. 2, 2017, 3:36 p.m.
Docstring.	brennie	Oct. 2, 2017, 3:37 p.m.
Blank line between these.	brennie	Oct. 2, 2017, 3:37 p.m.
E501 line too long (90 > 79 characters)	reviewbot	Oct. 2, 2017, 3:37 p.m.
E501 line too long (86 > 79 characters)	reviewbot	Oct. 2, 2017, 3:37 p.m.
E501 line too long (100 > 79 characters)	reviewbot	Oct. 2, 2017, 3:37 p.m.
E501 line too long (85 > 79 characters)	reviewbot	Oct. 2, 2017, 3:37 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Oct. 2, 2017, 3:37 p.m.
E501 line too long (90 > 79 characters)	reviewbot	Oct. 2, 2017, 3:37 p.m.
E501 line too long (91 > 79 characters)	reviewbot	Oct. 2, 2017, 3:37 p.m.
E501 line too long (91 > 79 characters)	reviewbot	Oct. 2, 2017, 3:37 p.m.
E501 line too long (93 > 79 characters)	reviewbot	Oct. 2, 2017, 3:38 p.m.
E501 line too long (88 > 79 characters)	reviewbot	Oct. 2, 2017, 3:38 p.m.
E501 line too long (88 > 79 characters)	reviewbot	Oct. 2, 2017, 3:38 p.m.
E501 line too long (109 > 79 characters)	reviewbot	Oct. 2, 2017, 3:38 p.m.
E501 line too long (97 > 79 characters)	reviewbot	Oct. 2, 2017, 3:38 p.m.
Undo.	brennie	Oct. 2, 2017, 3:19 p.m.
Undo.	brennie	Oct. 2, 2017, 3:19 p.m.
I'm not sure what we should put in here. Maybe ask David or Christian what they think?	brennie	Sept. 24, 2017, 2:44 p.m.
W291 trailing whitespace	reviewbot	Oct. 2, 2017, 3:51 p.m.
W291 trailing whitespace	reviewbot	Oct. 2, 2017, 3:52 p.m.
W291 trailing whitespace	reviewbot	Oct. 2, 2017, 3:51 p.m.
W291 trailing whitespace	reviewbot	Oct. 2, 2017, 3:51 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (86 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (101 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (84 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (91 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (91 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (93 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (88 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (88 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (90 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (91 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (91 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (93 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (88 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (88 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (95 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (90 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (86 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (100 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (85 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (81 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (90 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (91 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (91 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (93 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (88 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (88 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (109 > 79 characters)
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (97 > 79 characters)
```

Fix it!

The issue has been resolved. Show all issues

Pro tip: You can set a column width of 79 in pycharm settings. It is under Editor -> Code Style -> Python -> Wrapping and Braces.

slamo Oct. 2, 2017, 3:50 p.m.

Thank you, after reviewboard complained I had set it for all all languages in pycharm, but couldn't figure out how to set it for just python.

djblets/auth/tests/test_views.py (Diff revision 1)

The issue has been resolved. Show all issues

Needs a file-level docstring that describes what the file is or does. In this case "Unit tests for djblets.auth.views." would be fine.

djblets/auth/tests/test_views.py (Diff revision 1)

The issue has been resolved. Show all issues

These can be grouped together since they are both 3rd party imports.

djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Needs a docstring.
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Needs a docstring.
```

djblets/auth/tests/test_views.py (Diff revision 1)

The issue has been resolved. Show all issues

Formatting to flake8's complaints can be hard, so try:

self.csrf_client.get(
    reverse('register'),
    {
        'username': 'testUser',
        'password1': 'password',
        'password2': 'password',
        'email': 'user@gmail.com',
        'first_name': 'test',
        'last_name': 'user',
    },
)

djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Docstring.
```
djblets/auth/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
djblets/auth/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Undo.
```
djblets/auth/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Undo.
```

djblets/testing/templates/djblets_testing/register.html (Diff revision 1)

An issue was opened. Show all issues

I'm not sure what we should put in here. Maybe ask David or Christian what they think?

Commit:

-	b2d378cbe3851b1150c3c7012f7690e65bf9393d
+	13642a349d60435dfbc18e2d02ed7aaafab16bc5

Diff:

Revision 2 (+136 -7)

Show changes

	djblets/auth/forms.py
	djblets/auth/tests/test_views.py
	djblets/testing/urls.py
	djblets/testing/templates/djblets_testing/register.html

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

djblets/auth/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/auth/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/auth/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/auth/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```

djblets/auth/tests/test_views.py (Diff revision 2)

Is there a pycharm setting for deleting trailing whitespaces automatically on save?

Fix it!

An issue was opened. Show all issues

Please limit your summary to 50-ish chars.

Wrap summary & description at 72 chars.

brennie Oct. 3, 2017, 4:26 p.m.

Also, for your convenience, there is a setting in PyCharm that lets you strip trailing whitespace on save: Editor -> General -> Other -> Strip Trailing spaces on Save: Modified lines.

Review Board 7.0 alpha 0 (dev)

Added unit tests for djblets.auth.views.register. These unit tests cover registering a new user and attempting to register a user with an existing account/username.

Information

Reviewers

flake8

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Status: Discarded