Added unit tests for djblets.auth.views.register. These unit tests cover registering a new user and attempting to register a user with an existing account/username.
Review Request #9219 — Created Sept. 24, 2017 and discarded
Added unit tests for djblets.auth.views.register. These unit tests cover registering a new user and attempting to register a user with an existing account/username.
Stepped through djblets.auth.views.register using ipdb to make sure that each test was hitting the proper registration flows.
Description | From | Last Updated |
---|---|---|
Pro tip: You can set a column width of 79 in pycharm settings. It is under Editor -> Code Style … |
brennie | |
Please limit your summary to 50-ish chars. Wrap summary & description at 72 chars. |
brennie | |
Needs a file-level docstring that describes what the file is or does. In this case "Unit tests for djblets.auth.views." would … |
brennie | |
These can be grouped together since they are both 3rd party imports. |
brennie | |
Needs a docstring. |
brennie | |
Needs a docstring. |
brennie | |
E501 line too long (86 > 79 characters) |
reviewbot | |
E501 line too long (101 > 79 characters) |
reviewbot | |
E501 line too long (84 > 79 characters) |
reviewbot | |
Formatting to flake8's complaints can be hard, so try: self.csrf_client.get( reverse('register'), { 'username': 'testUser', 'password1': 'password', 'password2': 'password', 'email': 'user@gmail.com', … |
brennie | |
E501 line too long (91 > 79 characters) |
reviewbot | |
E501 line too long (91 > 79 characters) |
reviewbot | |
E501 line too long (93 > 79 characters) |
reviewbot | |
E501 line too long (88 > 79 characters) |
reviewbot | |
E501 line too long (88 > 79 characters) |
reviewbot | |
E501 line too long (90 > 79 characters) |
reviewbot | |
E501 line too long (91 > 79 characters) |
reviewbot | |
E501 line too long (91 > 79 characters) |
reviewbot | |
E501 line too long (93 > 79 characters) |
reviewbot | |
E501 line too long (88 > 79 characters) |
reviewbot | |
E501 line too long (88 > 79 characters) |
reviewbot | |
E501 line too long (95 > 79 characters) |
reviewbot | |
Docstring. |
brennie | |
Blank line between these. |
brennie | |
E501 line too long (90 > 79 characters) |
reviewbot | |
E501 line too long (86 > 79 characters) |
reviewbot | |
E501 line too long (100 > 79 characters) |
reviewbot | |
E501 line too long (85 > 79 characters) |
reviewbot | |
E501 line too long (81 > 79 characters) |
reviewbot | |
E501 line too long (90 > 79 characters) |
reviewbot | |
E501 line too long (91 > 79 characters) |
reviewbot | |
E501 line too long (91 > 79 characters) |
reviewbot | |
E501 line too long (93 > 79 characters) |
reviewbot | |
E501 line too long (88 > 79 characters) |
reviewbot | |
E501 line too long (88 > 79 characters) |
reviewbot | |
E501 line too long (109 > 79 characters) |
reviewbot | |
E501 line too long (97 > 79 characters) |
reviewbot | |
Undo. |
brennie | |
Undo. |
brennie | |
I'm not sure what we should put in here. Maybe ask David or Christian what they think? |
brennie | |
W291 trailing whitespace |
reviewbot | |
W291 trailing whitespace |
reviewbot | |
W291 trailing whitespace |
reviewbot | |
W291 trailing whitespace |
reviewbot |
-
-
Pro tip: You can set a column width of 79 in pycharm settings. It is under Editor -> Code Style -> Python -> Wrapping and Braces.
-
Needs a file-level docstring that describes what the file is or does. In this case "Unit tests for djblets.auth.views." would be fine.
-
-
-
-
Formatting to flake8's complaints can be hard, so try:
self.csrf_client.get( reverse('register'), { 'username': 'testUser', 'password1': 'password', 'password2': 'password', 'email': 'user@gmail.com', 'first_name': 'test', 'last_name': 'user', }, )
-
-
-
-
-