Change e-mail sending to use <Name> via Review Board when e-mail spoofing disabled.

Review Request #9216 - Created Sept. 24, 2017 and updated

Brian LeBlanc
Djblets
release-0.10.x
4578
9209
2179201...
djblets, students

When e-mail messages are created with enabled_smart_spoofing disabled,
the 'From' header should match a DMARC failure but instead the original
from_address is used.

This changes makes e-mail messages copy the same functionality as DMARC
not allowing spoofing when enable_smart_spoofing is disabled. This
changes the mail tests to expect the change in functionality when
enable_smart_spoofing is False.

This change is from the comments on the review for adding an option for
disabling e-mail smart spoofing (https://reviews.reviewboard.org/r/9209).

The full testing suite for djblets was run.

  • 0
  • 0
  • 7
  • 0
  • 7
Description From Last Updated
Barret Rennie
Barret Rennie
Brian LeBlanc
Barret Rennie
Christian Hammond
Brian LeBlanc
Brian LeBlanc
Review request changed

Change Summary:

Add test case for enable_smart_spoofing=False.

Commit:

-779e35857216724e8a37361aaf34fb622d1932b3
+2179201c0db5dfbd7d4ed0a6741893b1f812ffd6

Diff:

Revision 4 (+59 -16)

Show changes

Checks run (2 succeeded)

JSHint passed.
flake8 passed.
Loading...