~ | | Fixed an issue (#4492) with closed review requests "submitted at" timestamp (actually using the "last updated" field) being updated by subsequent comments (and possibly other activity), resulting in review requests being listed as having been submitted/closed recently, when in actuality the submission had been closed further in the past. |
| ~ | Closed review requests were having their "submitted at" timestamps updated by
|
| + | subsequent comments on the request. This led to situations where requests that
|
| + | had been long since submitted were updated and erroneously listed as having been
|
| + | submitted relative to the timestamp of the most recent comment/activity. This
|
| + | error was caused due to the "submitted at" section using the "last updated"
|
| + | field of the review request. |
| |
|
~ | | Per Christian's suggestion, the fix involved re-writing the method "get_close_description" of the review request model into a new method "get_close_info", which returns a python dictionary including the values returned by "get_close_description", as well as a timestamp indicating when the review request had been closed. This timestamp was then used instead of the "last updated" timestamp for submitted review requests. "get_close_description" was also re-written to wrap the new "get_close_info" method, and now raises deprecation warnings on use. |
| ~ | The submitted fix involves re-writing the method get_close_description of
|
| + | the review request model into a new method get_close_info , which returns a
|
| + | python dictionary including the values returned by get_close_description ,
|
| + | as well as a timestamp indicating when the review request had been closed.
|
| + | This timestamp was then used instead of the "last updated" timestamp for
|
| + | submitted review requests. get_close_description was also re-written to
|
| + | wrap the new get_close_info method, and now raises a deprecation
|
| + | warning on use. |