Fixed the issue of publishing from web API without reviewers or groups specified.

Review Request #9210 - Created Sept. 23, 2017 and updated

Mukhtar Alhejji
Review Board
release-3.0.x
4057
ae36187...
reviewboard, students
mukhtar

When creating a new review request with no reviewer or groups
assigned, attempting to publish it with PUT will be sucessful.
However, it shouldn't allow that as review requests must have a
reviewer. The issue is solved by adding conditions to validate the
review draft on the server.

Added a unit test, which passes (along with all other tests).

  • Created a draft test review that don't have a reviewer/group name.
  • Ran it using this command ./tests/runtests.py
    reviewboard.reviews.tests.test_review_request_draft
  • This will raise a publishingError since there isn't reviewer.
  • 0
  • 0
  • 59
  • 6
  • 65
Description From Last Updated
Christian Hammond
Mukhtar Alhejji
Mukhtar Alhejji
Mukhtar Alhejji
Mukhtar Alhejji
Mukhtar Alhejji
Mike Conley
Mukhtar Alhejji
Mukhtar Alhejji
Barret Rennie
Mukhtar Alhejji
Barret Rennie
Christian Hammond
Mukhtar Alhejji
Mukhtar Alhejji
Mukhtar Alhejji
Barret Rennie
Mukhtar Alhejji
Mike Conley
Mukhtar Alhejji
Review request changed
Loading...