Rename pageView to basePageView to get around adblockers

Review Request #9202 — Created Sept. 22, 2017 and submitted

brennie
Review Board
release-3.0.x
fd04915...
reviewboard

Apparently pageView is a common name for some ad network and ad blockers
will prevent the file from loading from the development server.

Verified that the file is not blocked from loading by my ad blocker.

Description From Last Updated

The class name should be renamed to match. Description could use a little more fleshing out. Testing Done as well ...

chipx86chipx86
david
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. The class name should be renamed to match.

    Description could use a little more fleshing out. Testing Done as well (unit tests).

  3. 
      
mike_conley
  1. 
      
  2. reviewboard/staticbundles.py (Diff revision 1)
     
     

    Wow, TIL. Is there a list of blacklisted filenames that we should have for reference somewhere?

    1. This one came on my radar recently (for the review request page). It's a bit of a moving target... Only really a major problem in development (wonder why ad blockers don't ignore localhost).

  3. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (c83e2a5)
Loading...