Summary

Rename pageView to basePageView to get around adblockers

Review Request #9202 — Created Sept. 22, 2017 and submitted Sept. 23, 2017, 11:46 a.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

fd04915...

Reviewers

Groups

reviewboard

People

Description

Apparently pageView is a common name for some ad network and ad blockers
will prevent the file from loading from the development server.

Testing Done

Verified that the file is not blocked from loading by my ad blocker.

Issues

Description	From	Last Updated
The class name should be renamed to match. Description could use a little more fleshing out. Testing Done as well …	chipx86	Sept. 23, 2017, 7:11 a.m.

flake8 passed.

JSHint internal error.

Ship it!

```
Ship It!
```

Fix it!

An issue was opened. Show all issues

The class name should be renamed to match.
Description could use a little more fleshing out. Testing Done as well (unit tests).

reviewboard/staticbundles.py (Diff revision 1)

Wow, TIL. Is there a list of blacklisted filenames that we should have for reference somewhere?

chipx86 Sept. 23, 2017, 7:48 a.m.

This one came on my radar recently (for the review request page). It's a bit of a moving target... Only really a major problem in development (wonder why ad blockers don't ignore localhost).

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (c83e2a5)