Clean up some regressed visuals in the diff viewer.

Review Request #9187 - Created Sept. 9, 2017 and submitted

Christian Hammond
Review Board
release-3.0.x
128d1e0...
reviewboard

Some of the recent template and style work made bits of the diff viewer
look a bit ugly. The issue summary table was always present (but empty),
and the diff entries being loaded had a white background behind the
spinner.

This change makes the issue summary table's display conditional,
enabling it only for the review request page. It also changes the look
of the diff entries to have the spinner before the filename, creating a
nice visual consistency and making the entries look nice and slim.

It also moves some padding from .sidebyside.loading into its tbody,
to avoid an issue with the wrong color appearing along the edges.

Viewed the diff viewer page and saw that the issue summary table was no
longer there, and that the diff placeholder entries looked a lot nicer.

Made sure that the issue summary table was visible on the main review
request page.

Loading file attachments...

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
David Trowbridge
  1. Ship It!
  2. 
      
David Trowbridge
  1. 
      
  2. Wait, what's this white line on the left?

  3. 
      
Christian Hammond
Christian Hammond
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (fbcbfc3)
Loading...