Clean up some regressed visuals in the diff viewer.
Review Request #9187 — Created Sept. 8, 2017 and submitted
Some of the recent template and style work made bits of the diff viewer
look a bit ugly. The issue summary table was always present (but empty),
and the diff entries being loaded had a white background behind the
spinner.This change makes the issue summary table's display conditional,
enabling it only for the review request page. It also changes the look
of the diff entries to have the spinner before the filename, creating a
nice visual consistency and making the entries look nice and slim.It also moves some padding from
.sidebyside.loading
into itstbody
,
to avoid an issue with the wrong color appearing along the edges.
Viewed the diff viewer page and saw that the issue summary table was no
longer there, and that the diff placeholder entries looked a lot nicer.Made sure that the issue summary table was visible on the main review
request page.
Description | From | Last Updated |
---|---|---|
Wait, what's this white line on the left? |
david |
- Change Summary:
-
Fixed up some excess color around the edges of the table.
- Description:
-
Some of the recent template and style work made bits of the diff viewer
look a bit ugly. The issue summary table was always present (but empty), and the diff entries being loaded had a white background behind the spinner. This change makes the issue summary table's display conditional,
enabling it only for the review request page. It also changes the look of the diff entries to have the spinner before the filename, creating a nice visual consistency and making the entries look nice and slim. + + It also moves some padding from
.sidebyside.loading
into itstbody
,+ to avoid an issue with the wrong color appearing along the edges. - Commit:
-
eb3512eca087b1ba842619fc684975b6d694519b128d1e08a79dfc16e8f69e7f9de68ae0b35dbdd2