Add interactive UI for comment issue verification.

 






 

 


  Review Request #9173
  —
  Created Sept. 6, 2017 and submitted 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-3.0.x
 









 
 

  
 









 
 

  
 









 
 

  4a102df...
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
A previous change added the UI for displaying the "Waiting for verification"

state. This change adds the UI to enable and manipulate that state.

 








  


 
 

  
    

  • Created new comments via the comment dialog and the review dialog and
    
  verified that the "Require verification" checkbox correctly persisted into
    
  extra_data for both cases.
    • 

  • Checked the state transitions from open -> verify and verify -> closed
    
  for both "Fixed" and "Dropped" cases.
    • 

  • Ran js-tests.
    • 

  • Ran unit tests.
    • 


 







 









 





  








 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Col: 18 ['require_verification'] is better written in dot notation.

      		
      
       reviewbotreviewbot
      
      
       
      
     




     

      
       
       
Can you add docs here, and use @property and @property.setter for these?

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
Docs here, too.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
I think you might need a blank line here for it to render properly.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
These can be in the return below.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
Let's also factor in Local Site admins, maybe also add a permission for this?

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
Can you compare user.pk to self.get_review().user_id to optimistically prevent a query on the user?

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
Col: 58 Missing semicolon.

      		
      
       reviewbotreviewbot
      
      
       
      
     




     

      
       
       
I don't know that #: will work reliably here. property includes a doc= keyword argument that should be used instead.

      		
      
       chipx86chipx86
      
      
       
      
     


    
   

  

 







 






  

 



















 




 

  


   

   

    
 
Checks run (1 failed, 1 succeeded)


    
   


  

  

  





 

 flake8
 passed.
 





 

 JSHint
 failed.
 
















 
JSHint

 


 







  

 





 














 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  











 



  

   
Commit:

   
    
-70cda4dc6e88ab52819cf7bc5b20dd02971371db
+37367cd3ee71305e4796ab830ad7f2ded3e473ff

   		
  




  

   
Diff:

   
    
 Revision 2 (+348 -51)
Show changes
 
    reviewboard/reviews/models/base_comment.py 
    reviewboard/reviews/templatetags/reviewtags.py 
    reviewboard/static/rb/js/models/commentEditorModel.es6.js 
    reviewboard/static/rb/js/models/commentIssueManagerModel.es6.js 
    reviewboard/static/rb/js/models/tests/commentEditorModelTests.js 
    reviewboard/static/rb/js/resources/models/baseCommentModel.es6.js 
    reviewboard/static/rb/js/reviewRequestPage/views/reviewView.es6.js 
    reviewboard/static/rb/js/views/commentDialogView.es6.js 
  5 more
 

   		
  



 









 

  
Checks run (1 failed, 1 succeeded)



  

 flake8
 passed.
 





  

 JSHint
 failed.
 





 










 
JSHint

 


 












  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Can you add docs here, and use @property and @property.setter for these?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I have documentation for the property itself. Documenting the setter and getter individually seems weird, since those docstrings will get subsumed by the property.
      
 
      

      2. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Docs here, too.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      reviewboard/reviews/models/base_comment.py
      


       (Diff revision 2)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    I think you might need a blank line here for it to render properly.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      We don't have that in other places that use this format, so I'll keep it as-is.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      The other ones are wrong. I just confirmed that this will fail to render. A blank line is required in the spec.
      
 
      

      3. 


 
    


    

 
    

    5. 






  5. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      reviewboard/reviews/models/base_comment.py
      


       (Diff revision 2)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    These can be in the return below.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 






  6. 
 
    
  
  
    
  
 

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Let's also factor in Local Site admins, maybe also add a permission for this?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    7. 






  7. 
 
    
  
  
    
  
 

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Can you compare user.pk to self.get_review().user_id to optimistically prevent a query on the user?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    8. 




  8. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    9. 




  

 
















 



 

  

   




david




   

   

  

 



 















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      reviewboard/reviews/models/base_comment.py
      


       (Diff revision 3)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    I don't know that #: will work reliably here. property includes a doc= keyword argument that should be used instead.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




chipx86




   

   





  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-3.0.x (d2ee7fa)





 


 










  

 









     

    

   

  

  

   
   Loading...