flake8
passed.
JSHint
failed.
Add interactive UI for comment issue verification.
Review Request #9173 — Created Sept. 6, 2017 and submitted
A previous change added the UI for displaying the "Waiting for verification"
state. This change adds the UI to enable and manipulate that state.
- Created new comments via the comment dialog and the review dialog and
verified that the "Require verification" checkbox correctly persisted into
extra_data for both cases. - Checked the state transitions from open -> verify and verify -> closed
for both "Fixed" and "Dropped" cases. - Ran js-tests.
- Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Col: 18 ['require_verification'] is better written in dot notation. |
 reviewbot
|
|
|
Can you add docs here, and use @property and @property.setter for these? |
 chipx86
|
|
|
Docs here, too. |
chipx86
|
|
|
I think you might need a blank line here for it to render properly. |
chipx86
|
|
|
These can be in the return below. |
chipx86
|
|
|
Let's also factor in Local Site admins, maybe also add a permission for this? |
chipx86
|
|
|
Can you compare user.pk to self.get_review().user_id to optimistically prevent a query on the user? |
chipx86
|
|
|
Col: 58 Missing semicolon. |
reviewbot
|
|
|
I don't know that #: will work reliably here. property includes a doc= keyword argument that should be used instead. |
chipx86
|
- Commit:
-
70cda4dc6e88ab52819cf7bc5b20dd02971371db37367cd3ee71305e4796ab830ad7f2ded3e473ff
- Diff:
-
Revision 2 (+348 -51)
- Commit:
-
37367cd3ee71305e4796ab830ad7f2ded3e473ffef3c4d512a8b1fff6e01dabe9c14e4255d043283
- Diff:
-
Revision 3 (+352 -51)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Commit:
-
ef3c4d512a8b1fff6e01dabe9c14e4255d0432834a102df5060b154d4820479ea70888dd2b976a3b
- Diff:
-
Revision 4 (+353 -51)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.