Add date fields for review requests.
Review Request #9158 — Created Aug. 29, 2017 and submitted — Latest diff uploaded
This change adds Python and JavaScript classes to add date-type fields in
review requests. Extensions can use this very simply by just subclassing
BaseDropdownField and providingfield_id
andlabel
attributes. The
resulting value will be stored inextra_data
as expected.
- Ran js-tests.
- Ran unit tests.
- Created a test extension that used a date field and verified that the
state was correctly rendered when loading the page and correctly stored when
the date was changed. Verified that invalid dates were cleared out.
Diff Revision 1
This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.
orig
1
2
3
reviewboard/reviews/fields.py |
---|
reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js |
---|