Add date fields for review requests.

Review Request #9158 - Created Aug. 29, 2017 and submitted

David Trowbridge
Review Board
release-3.0.x
580e7f9...
reviewboard

This change adds Python and JavaScript classes to add date-type fields in
review requests. Extensions can use this very simply by just subclassing
BaseDropdownField and providing field_id and label attributes. The
resulting value will be stored in extra_data as expected.

  • Ran js-tests.
  • Ran unit tests.
  • Created a test extension that used a date field and verified that the
    state was correctly rendered when loading the page and correctly stored when
    the date was changed. Verified that invalid dates were cleared out.
  • 0
  • 0
  • 7
  • 0
  • 7
Description From Last Updated
Checks run (2 failed)
flake8 failed.
JSHint failed.

flake8

JSHint

David Trowbridge
Christian Hammond
  1. 
      
  2. "Python" and "JavaScript" in the description.

  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    Something bad happened here.

  4. reviewboard/reviews/fields.py (Diff revision 2)
     
     

    "JavaScript"

  5. Blank line between these.

  6. 
      
David Trowbridge
David Trowbridge
Christian Hammond
  1. 
      
  2. reviewboard/reviews/fields.py (Diff revision 3)
     
     
  3. 
      
David Trowbridge
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (336c23a)
Loading...