Summary

Add date fields for review requests.

Review Request #9158 — Created Aug. 29, 2017 and submitted Sept. 26, 2017, 10:38 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

580e7f9...

Reviewers

Groups

reviewboard

People

Description

This change adds Python and JavaScript classes to add date-type fields in
review requests. Extensions can use this very simply by just subclassing
BaseDropdownField and providing field_id and label attributes. The
resulting value will be stored in extra_data as expected.

Testing Done


Ran js-tests.
Ran unit tests.
Created a test extension that used a date field and verified that the

  state was correctly rendered when loading the page and correctly stored when

  the date was changed. Verified that invalid dates were cleared out.

Issues

Description	From	Last Updated
"Python" and "JavaScript" in the description.	chipx86	Sept. 8, 2017, 11:12 a.m.
F401 'django.utils.timezone' imported but unused	reviewbot	Aug. 29, 2017, 3:39 p.m.
Col: 15 '$field' is defined but never used.	reviewbot	Aug. 29, 2017, 3:39 p.m.
Something bad happened here.	chipx86	Sept. 8, 2017, 11:10 a.m.
"JavaScript"	chipx86	Sept. 8, 2017, 11:10 a.m.
Blank line between these.	chipx86	Sept. 8, 2017, 11:11 a.m.
bool	chipx86	Sept. 26, 2017, 10:37 a.m.

flake8 failed.

JSHint failed.

flake8

reviewboard/reviews/fields.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'django.utils.timezone' imported but unused
```

JSHint

reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 15
 '$field' is defined but never used.
```

Commit:

-	e2ca82c8565876a551164ed94c62e598d8e9ac82
+	81498d88744556494f268a488842984c89090a5e

Diff:

Revision 2 (+78 -1)

Show changes

	reviewboard/reviews/fields.py
	reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

"Python" and "JavaScript" in the description.

reviewboard/reviews/fields.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Something bad happened here.
```
reviewboard/reviews/fields.py (Diff revision 2)
The issue has been resolved. Show all issues
```
"JavaScript"
```
reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Blank line between these.
```

Description:

~		This change adds python and javascript classes to add date-type fields in
	~	This change adds Python and JavaScript classes to add date-type fields in
		review requests. Extensions can use this very simply by just subclassing
		BaseDropdownField and providing `field_id` and `label` attributes. The
		resulting value will be stored in `extra_data` as expected.

Commit:

-	81498d88744556494f268a488842984c89090a5e
+	580e7f91def8a9e4766b75cace4d94d5f5767a35

Diff:

Revision 3 (+78)

Show changes

	reviewboard/reviews/fields.py
	reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/reviews/fields.py (Diff revision 3)
The issue has been resolved. Show all issues
```
bool
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (336c23a)