Add dropdown fields for review requests.
Review Request #9157 — Created Aug. 29, 2017 and submitted
This change adds Python and JavaScript classes to add dropdown-type fields in
review requests. Extensions can use this very simply by just subclassing
BaseDropdownField and providingfield_id
,label
, andoptions
attributes.
The resulting value will be stored inextra_data
as expected.
- Ran js-tests.
- Ran unit tests.
- Created a test extension that used a dropdown field and verified that the
state was correctly rendered when loading the page and correctly stored
when the dropdown was changed.
Description: |
|
|||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||||||||
Diff: |
Revision 2 (+114 -1) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.