Add dropdown fields for review requests.

Review Request #9157 - Created Aug. 29, 2017 and updated

David Trowbridge
Review Board
release-3.0.x
cb64f1f...
reviewboard

This change adds Python and JavaScript classes to add dropdown-type fields in
review requests. Extensions can use this very simply by just subclassing
BaseDropdownField and providing field_id, label, and options attributes.
The resulting value will be stored in extra_data as expected.

  • Ran js-tests.
  • Ran unit tests.
  • Created a test extension that used a dropdown field and verified that the
    state was correctly rendered when loading the page and correctly stored
    when the dropdown was changed.
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
Christian Hammond
David Trowbridge
Review request changed

Description:

~  

This change adds python and javascript classes to add dropdown-type fields in

  ~

This change adds Python and JavaScript classes to add dropdown-type fields in

    review requests. Extensions can use this very simply by just subclassing
    BaseDropdownField and providing field_id, label, and options attributes.
    The resulting value will be stored in extra_data as expected.

Commit:

-43ede0c8faefbc1ea3eb20d86d5379d8c0c216eb
+cb64f1f50583f18e310b33ba97efc636b6a98f30

Diff:

Revision 2 (+114 -1)

Show changes

Checks run (2 succeeded)

JSHint passed.
flake8 passed.
Loading...