Add dropdown fields for review requests.

Review Request #9157 - Created Aug. 29, 2017 and submitted

David Trowbridge
Review Board
release-3.0.x
cb64f1f...
reviewboard

This change adds Python and JavaScript classes to add dropdown-type fields in
review requests. Extensions can use this very simply by just subclassing
BaseDropdownField and providing field_id, label, and options attributes.
The resulting value will be stored in extra_data as expected.

  • Ran js-tests.
  • Ran unit tests.
  • Created a test extension that used a dropdown field and verified that the
    state was correctly rendered when loading the page and correctly stored
    when the dropdown was changed.
  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
Christian Hammond
  1. 
      
  2. "Python" and "JavaScript" in the description.

  3. reviewboard/reviews/fields.py (Diff revision 1)
     
     

    "JavaScript"

  4. reviewboard/reviews/fields.py (Diff revision 1)
     
     
  5. reviewboard/reviews/fields.py (Diff revision 1)
     
     

    Can you escape <option>?

  6. reviewboard/reviews/fields.py (Diff revision 1)
     
     

    django.utils.safestring.SafeText

  7. 
      
David Trowbridge
Christian Hammond
  1. Ship It!
  2. 
      
David Trowbridge
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (4337cba)
Loading...